AI_Assistant/pcbjam
Watch
1
0
Fork
You've already forked pcbjam
 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity Actions

test(determinism): annotate CvPcb spec dwells so lint:determinism passes

Browse source 
The three page.waitForTimeout calls in eeschema-assign-footprints.spec.ts
are legitimate interaction dwells (two poll intervals that pump the wx
event loop inside asserting loops, one first-paint settle before a
screenshot), but were unannotated, so the determinism guard failed CI.
Mark each with a `dwell:` note per tests/TESTING.md.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Istvan Matejcsok 2026-07-17 20:21:43 +02:00
commit 0b0e8e9646
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/web/eeschema-assign-footprints.spec.ts
View file

@ -136,7 +136,7 @@ test('Tools → Assign Footprints opens CvPcb (merged third kiface)', async ({ p
for (let i = 0; i < 60 && !up; i++) { for (let i = 0; i < 60 && !up; i++) {
await page.mouse.move(c.x + (i % 5) * 4, c.y + (i % 3) * 4); await page.mouse.move(c.x + (i % 5) * 4, c.y + (i % 3) * 4);
up = await cvpcbUp(page); up = await cvpcbUp(page);
if (!up) await page.waitForTimeout(1000); if (!up) await page.waitForTimeout(1000); // dwell: poll interval while pumping the wx event loop; the surrounding loop asserts `up`
} }
if (!up) { if (!up) {
@ -161,7 +161,7 @@ test('Tools → Assign Footprints opens CvPcb (merged third kiface)', async ({ p
// Let the frame finish its first paint (footprint/symbol panes), then shoot // Let the frame finish its first paint (footprint/symbol panes), then shoot
// for eyeball review of the three-pane UI. // for eyeball review of the three-pane UI.
await page.mouse.move(c.x + 2, c.y + 2); await page.mouse.move(c.x + 2, c.y + 2);
await page.waitForTimeout(2000); await page.waitForTimeout(2000); // dwell: let the frame finish its first paint before the eyeball screenshot
await page.screenshot({ path: SHOT('02-cvpcb'), scale: 'css' }); await page.screenshot({ path: SHOT('02-cvpcb'), scale: 'css' });
// The footprint pane is fed over the wasm↔js libs bridge — poll until // The footprint pane is fed over the wasm↔js libs bridge — poll until
@ -174,7 +174,7 @@ test('Tools → Assign Footprints opens CvPcb (merged third kiface)', async ({ p
); );
if (fpCalls.length > 0) break; if (fpCalls.length > 0) break;
await page.mouse.move(c.x + (i % 5) * 3, c.y + (i % 3) * 3); await page.mouse.move(c.x + (i % 5) * 3, c.y + (i % 3) * 3);
await page.waitForTimeout(1000); await page.waitForTimeout(1000); // dwell: poll interval while pumping the wx loop; the surrounding loop asserts fpCalls
} }
console.log( console.log(
`[cvpcb-open] fp bridge calls: ${JSON.stringify(fpCalls.map((call) => [call[0], call[1], call[2], call[4]]))}`, `[cvpcb-open] fp bridge calls: ${JSON.stringify(fpCalls.map((call) => [call[0], call[1], call[2], call[4]]))}`,