2026-06-03 08:52:34 +02:00
|
|
|
import { test, expect } from './fixtures';
|
2026-07-07 10:50:24 +02:00
|
|
|
import { stableShot } from '../e2e/utils/element-tracker';
|
2026-06-03 08:52:34 +02:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* pl_editor (drawing-sheet editor) programmatic-open regression.
|
|
|
|
|
*
|
|
|
|
|
* Guards the web-app wiring added for pl_editor:
|
|
|
|
|
* 1. the generic kicadOpenFile() embind hook (wasm/bindings/pl_editor_embind.cpp)
|
|
|
|
|
* — PL_EDITOR_FRAME overrides OpenProjectFiles, so a .kicad_wks can be opened
|
|
|
|
|
* deterministically without UI automation, and
|
|
|
|
|
* 2. the seeded KiCad config that skips the first-run STARTWIZARD (the harness
|
|
|
|
|
* now seeds it in preRun, matching the web app's boot.ts) — without it the
|
jspi cleanup: remove the asyncify-era residue — dead code, conditionals, pipeline scaffolding, stale prose
The runtime is JSPI-only; this removes everything that still pretended
otherwise. Three exhaustive sweeps (C++/JS+build+CI/tests+docs) drove
the inventory; every deletion verified by grep closure + full gates.
Broken-right-now fixes:
- deploy-staging.yml passed the retired opt_level input — the workflow
could not even start. Removed.
- env.sh carried dead exports with a live -sASYNCIFY=1 inside
(WASM_LDFLAGS/PTHREAD_LDFLAGS, zero consumers). Removed; the
WASM_LEGACY_EXCEPTIONS rationale rewritten to the real reason.
- docker/build.sh exported PCBJAM_ASYNC_BACKEND (read nowhere). Gone.
Dead weight removed:
- binaryen submodule (nothing builds or invokes it), wasm-opt-bench
workflow + scripts/bench/, get-wasm-opt.sh, diagnostics.js (242 lines
of Asyncify-API-only code), the KICAD_PIPELINE background-postprocess
scaffolding (existed to parallelize the deleted wasm-opt phase; the
postprocess is a seconds-long node script and now runs inline),
build-monitor's dead asyncify rows, sched-context orphan build
output, dead .gitignore entries, the .jspi-assets spike dir (the two
wf-result research JSONs moved to docs/features/async/migration-evidence/).
- bindings: fiber_park.h + its 12 embind registrations (broken-if-
called under JSPI), the kicadOpenFileStart/OPEN_JOB starter route,
main_stack_runner.h + 5 includes, the always-null context-sleep weak
hook in nanosleep_yield.c.
- shim: the backend field (installed-flag idempotency instead),
noteContextWait (dead both sides), the __wxAsyncifyDump alias (+ the
WasmTool fallback and string-dump normalize branch).
- web: the emscripten-6-ignored mainScriptUrlOrBlob option in boot.ts
(gerber-demo keeps it: it loads the deployed CDN release, which
predates emscripten 6 — noted inline).
Conditionals: all 'backend === jspi' checks reduced to scheduler-
presence checks; races_quiescent re-keyed from Asyncify.state (vacuous)
to real backlog quiescence (resumeReady/mutatorQueue — NOT _windowLive,
which is the probing activation's own window by definition).
Renames (identifiers only, no file renames): ASYNC_LINK_FLAGS→
JSPI_LINK_FLAGS and Makefile ASYNC_LDFLAGS→JSPI_LDFLAGS,
kicadCollabFiberBusy→kicadCollabBusy (embind + web + tests),
collab_common.h fiber*→apply*/coroutine naming, asyncifySignatures→
wasmTrapSignatures (lists byte-identical).
Tests: the two remaining vacuous [wx-asyncify]/fiber-resume-refused
asserts re-keyed to live JSPI beacons; eeschema-load's failure message
no longer sends the developer to a deleted script; wait-beacons' dead
families/parser deleted; lane-0 legacy-glue guards removed (lane 0 is
unconstructible); the embind test.fail re-gated with the JSPI reason
(plain embind invokers cannot suspend — verified still failing);
lint-determinism now scans tests/jspi (166 files clean);
eeschema-collab local-move gated to chromium (~50% flaky on FF even
solo; pcbnew twin covers both engines).
Docs: DEBUG.md rewritten as the JSPI debugging guide; build.md
describes the single-phase build; docs/features/async/README.md
banner-marked historical and repointed at the NEW
23-jspi-runtime.md (current architecture: export census, turnstile,
libcontext ownership + refusal contract, embind call shapes, the
em-pthread service-wrapper trick, exception policy, known gaps).
Gates on the cleaned tree: test:e2e 725 passed / 0 failed (after the
quiescence-probe fix; the 3 other reds were verified contention flakes
solo-green or the documented FF gate), web 76/0, jspi 18/18 both
engines, vitest 295/295 + 17/17, all lints green, live-app census
clean.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016X9eh1s5sTx1o9Em9KBuwR
2026-08-14 09:25:32 +02:00
|
|
|
* wizard's modal loop wedges the boot and no file can load.
|
2026-06-03 08:52:34 +02:00
|
|
|
*
|
|
|
|
|
* Strategy mirrors eeschema-load.spec.ts: write a minimal .kicad_wks into MEMFS,
|
|
|
|
|
* call Module.kicadOpenFile(), and poll the editor title. GREEN once it shows the
|
|
|
|
|
* file name; also asserts no setup wizard is visible and no WASM abort fired.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
const SAMPLE_WKS = `(page_layout
|
|
|
|
|
(setup (textsize 1.5 1.5)(linewidth 0.15)(textlinewidth 0.15)
|
|
|
|
|
(left_margin 10)(right_margin 10)(top_margin 10)(bottom_margin 10))
|
|
|
|
|
(rect (name border:Rect) (start 0 0 ltcorner) (end 0 0 rbcorner) (comment "page border"))
|
|
|
|
|
(rect (name titleblock:Rect) (start 110 34) (end 2 2) (comment "title block frame"))
|
|
|
|
|
(tbtext "KiCad WASM — Drawing Sheet Load Test" (name title) (pos 100 20) (font (size 2.5 2.5) (bold)))
|
|
|
|
|
)
|
|
|
|
|
`;
|
|
|
|
|
|
|
|
|
|
type EmscriptenFS = {
|
|
|
|
|
mkdirTree(path: string): void;
|
|
|
|
|
writeFile(path: string, data: string): void;
|
|
|
|
|
};
|
|
|
|
|
type KicadModule = { kicadOpenFile(path: string): unknown };
|
|
|
|
|
|
|
|
|
|
function hasAbort(testLogger: { consoleLogs: string[]; errors: string[] }): boolean {
|
|
|
|
|
return [...testLogger.consoleLogs, ...testLogger.errors].some((l) => l.includes('Aborted('));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
test.describe('pl_editor drawing-sheet load', () => {
|
|
|
|
|
test('opens a .kicad_wks via kicadOpenFile, wizard-free', async ({ page, testLogger }) => {
|
|
|
|
|
await page.goto('/kicad/pl_editor.html');
|
|
|
|
|
|
|
|
|
|
// Editor must be fully up: canvas, registry, the embind open hook, and a
|
|
|
|
|
// top-level Frame (so kicadOpenFile's GetTopWindow() resolves to the editor).
|
|
|
|
|
await expect(page.locator('#canvas')).toBeVisible({ timeout: 90000 });
|
|
|
|
|
await page.waitForFunction(() => !!window.wxElementRegistry, null, { timeout: 90000 });
|
|
|
|
|
await page.waitForFunction(
|
|
|
|
|
() =>
|
|
|
|
|
typeof (window as unknown as { Module?: KicadModule }).Module?.kicadOpenFile ===
|
|
|
|
|
'function',
|
|
|
|
|
null,
|
|
|
|
|
{ timeout: 90000 }
|
|
|
|
|
);
|
|
|
|
|
await page.waitForFunction(
|
|
|
|
|
() =>
|
|
|
|
|
!!window.wxElementRegistry &&
|
|
|
|
|
window.wxElementRegistry
|
|
|
|
|
.findAll({ visible: true })
|
|
|
|
|
.some((e) => /Frame$/.test(e.typeName) || (e.name || '').endsWith('Frame')),
|
|
|
|
|
null,
|
|
|
|
|
{ timeout: 90000 }
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
// The seed must have suppressed the first-run wizard: no wizard/dialog up.
|
|
|
|
|
const wizardVisible = await page.evaluate(() => {
|
|
|
|
|
const reg = window.wxElementRegistry;
|
|
|
|
|
if (!reg) return -1;
|
|
|
|
|
return reg
|
|
|
|
|
.findAll({ visible: true })
|
|
|
|
|
.filter((e: { typeName: string }) => /^wxDialog|Wizard/.test(e.typeName)).length;
|
|
|
|
|
});
|
|
|
|
|
expect(wizardVisible, 'no setup wizard/dialog should be visible (seed skipped it)').toBe(0);
|
|
|
|
|
|
|
|
|
|
// Write a minimal drawing sheet into MEMFS and open it via the hook.
|
|
|
|
|
const openedPath = await page.evaluate((content) => {
|
|
|
|
|
const w = window as unknown as { FS: EmscriptenFS; Module: KicadModule };
|
|
|
|
|
const dir = '/home/kicad/documents';
|
|
|
|
|
try {
|
|
|
|
|
w.FS.mkdirTree(dir);
|
|
|
|
|
} catch {
|
|
|
|
|
/* already exists */
|
|
|
|
|
}
|
|
|
|
|
const path = `${dir}/load-test.kicad_wks`;
|
|
|
|
|
w.FS.writeFile(path, content);
|
|
|
|
|
w.Module.kicadOpenFile(path);
|
|
|
|
|
return path;
|
|
|
|
|
}, SAMPLE_WKS);
|
|
|
|
|
expect(openedPath).toContain('load-test.kicad_wks');
|
|
|
|
|
|
|
|
|
|
// The title switches to the opened file once the load completes.
|
|
|
|
|
await expect
|
|
|
|
|
.poll(async () => page.title(), {
|
|
|
|
|
message:
|
|
|
|
|
'Drawing sheet load did not complete (title never showed the file). ' +
|
|
|
|
|
'kicadOpenFile / the pl_editor embind hook is likely missing or broken.',
|
|
|
|
|
timeout: 30000,
|
|
|
|
|
intervals: [500],
|
|
|
|
|
})
|
|
|
|
|
.toMatch(/load-test/i);
|
|
|
|
|
|
2026-07-07 10:50:24 +02:00
|
|
|
await stableShot(page, 'pl_editor-load-rendered.png');
|
2026-06-03 08:52:34 +02:00
|
|
|
|
|
|
|
|
expect(hasAbort(testLogger), 'no WASM abort during open').toBe(false);
|
|
|
|
|
});
|
|
|
|
|
});
|