2026-07-06 15:59:51 +02:00
|
|
|
import type { Page } from "@playwright/test";
|
e2e/CI: dual-engine suites, per-engine screenshots, SwiftShader retired, prod web suite, CI-coverage gate
Squash of experiment/ff-big-modules vs main.
Big-module routing removed: native-EH shrank kicad_editor below
SpiderMonkey's x86-64 code budget (runs 29355049705/29356152413 green on
stock Firefox), so BIG_MODULE_SPECS routing and the baseline-only-JIT
crutch are gone — kicad-firefox and kicad-chromium both run the full
suite, with the module compiled the way real users' browsers compile it.
Per-engine screenshots end to end: stableShot/shotPath write
test-results/<engine>/<name>.png; baselines move to
baseline-screenshots/{chromium,firefox}/ and the whole tools/screenshots
pipeline (compare/promote/manifest/spec-map/changelog/Discord) keys on
<engine>/<name>. Previously Firefox and Chromium renders of one spec
overwrote each other and Firefox renders were never actually gated.
Seeded from CI run 29421380806 (92 new firefox baselines, +24 chromium
web-suite shots); manifest generated from the baseline tree.
One merged playwright.config.ts (kicad/asyncify/coroutine/perf as
projects); ~25 dead npm scripts dropped. The web suite is gated in CI for
the first time ever (4 rotted specs fixed, 5 broken lib-bridge specs
triaged as fixme in docs/features/web-e2e-rot/); cheap lint step after
npm ci; last 26 blind-sleep violations fixed.
SwiftShader retired: CI Chromium renders WebGL on ANGLE → Mesa llvmpipe
(--use-gl=angle --use-angle=gl --ignore-gpu-blocklist; the blocklist flag
is mandatory — llvmpipe is blocklisted and WebGL is silently unavailable
without it) in BOTH configs. Under WORKERS=4 congestion SwiftShader
transiently failed the first post-board-load draw and the recovery
cascade ended in a silent permanent Cairo fallback — that engine flip was
the "~1.2% changedRatio both directions" occ-export baseline flake.
Validated 160/160 across two 80-repeat rigs; full analysis in
docs/features/wx-parity-bugs/occ-export-context-eviction.md. Chromium
baselines shift slightly on llvmpipe — promote once from the first green
run. Deflakes the new coverage exposed: presence baselines settle before
capture; presence fixtures declare current file formats; perf gets its
own outputDir so CI evidence survives; occ-export settles the board paint
before the export dialog; menu-item waits (waitForRenderedByLabel before
clickMenuItem) in 4 specs + the TESTING.md rule.
Web suite runs the PROD build, in parallel: webServer becomes backend
`start` + the standalone's e2e:preview (build-preview.mjs: link-wasm →
stash the public/wasm symlink aside during vite build, build-demo.mjs's
move — then vite preview as the persistent server). The wasm middleware
serves /wasm/* in preview and emits COOP/COEP/CORP itself (a pthread
worker script's own response must carry COEP or Chrome kills it with
ERR_BLOCKED_BY_RESPONSE). VITE_* flags bake at build time;
VITE_ALLOW_USER_OVERRIDE joins turbo globalEnv. fullyParallel + default
workers: 5.2m → 1.4m. Determinism fixes the parallel run exposed:
shared-page specs become serial groups; locks.spec grabs alice's exact
item via the new kicadCollabTestSelectByUuid hook (cross-tab "first
footprint" order is not a ysync invariant); quit specs poll page.url()
(quit supersedes its own navigation — NS_BINDING_ABORTED on Firefox).
Suite: 51 passed / 12 skipped / 0 failed in 1.6m.
CI-coverage gate (lint:ci-coverage): every tests/**/*.spec.ts must be
reachable from the npm scripts the workflows invoke — scraped from
.github/workflows/, resolved through package.json, coverage asked from
playwright --list itself. Rules: uncovered-spec + orphan-project (with a
documented LOCAL_ONLY_PROJECTS allowlist). Gating next to
lint:determinism; 138 spec files / 13 projects accounted for.
Product fixes kept from the investigations (reachable on real GPUs too):
wx 7799fd1be5 — paint flags clear before dispatch + Invalidate always
propagates; kicad 3dcfea5e45 — SwiftShader pass-boundary flush +
per-instance font texture + first-frame GL-error drain (GAL recovery
recovers instead of falling back to Cairo) + the user-facing eeschema
switch navigates again under __EMSCRIPTEN__ (project-sync's
FaceRegistered gate had rerouted it into the hidden sync player; caught
by the newly-gated web suite).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018eUxiPApHgGiu9NFyQfhAq
2026-07-17 12:10:40 +02:00
|
|
|
import { settledShot } from "../e2e/utils/element-tracker";
|
2026-07-06 15:59:51 +02:00
|
|
|
import { test, expect } from "./fixtures";
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* pcbnew collab presence — C++ bridge e2e (collab-presence 0002).
|
|
|
|
|
*
|
|
|
|
|
* Covers the wasm side of presence in isolation (no yjs/awareness — that layer is
|
|
|
|
|
* unit-tested in the standalone and exercised end-to-end by tests/web):
|
|
|
|
|
* - selection emit: kicadCollabTestSelectFirst → window.kicadCollab.onSelection
|
|
|
|
|
* fires with the item's uuid; clear → fires with []. Real canvas CLICKS also
|
|
|
|
|
* drive the emit (the wx-layer trigger path).
|
|
|
|
|
* - cursor emit: synthetic mouse motion over the canvas → onCursor with world
|
|
|
|
|
* coords inside the board area; throttled; pointer-leave handled by the DOM
|
|
|
|
|
* leave event (not synthesizable reliably headless — covered in tests/web).
|
|
|
|
|
* - remote render, no state leak: kicadCollabSetRemote paints the VIEW_OVERLAY
|
|
|
|
|
* (canvas pixels change) while kicadCollabGetSelection stays [].
|
|
|
|
|
* - viewport export: kicadCollabGetViewport returns a sane transform.
|
|
|
|
|
*
|
|
|
|
|
* Board fixture mirrors pcbnew-collab.spec.ts (seeded harness, wizard-free).
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
const SEG1 = "44444444-0000-0000-0000-000000000001";
|
|
|
|
|
const FP1 = "66666666-0000-0000-0000-000000000001";
|
feat(collab): cross-app selection — eeschema symbol ⇄ pcbnew footprint ghost highlight (collab-presence 0006)
Selecting a symbol in eeschema ghost-highlights the linked footprint(s) in
every pcbnew tab of the project, and vice versa — across users AND one
user's own two tabs. Native KIWAY cross-probe is inert in WASM (one frame
per page); this rides the presence layer instead.
- cross-app.ts: project-wide awareness-only room (presenceRoomId), publishes
full PresenceState at selection rate (cursor always null); peers() = other-
TOOL clients incl. own user's other tabs; window.__pcbjamCrossApp test handle
- presence-kicad.ts: parseSelectionEmit (bare array | {uuids,fpPaths}),
xselFromPeerState (pcbnew paths → symbol uuids; eeschema uuids verbatim),
cross peers appended to the kicadCollabSetRemote snapshot as
{id "<user>#x<client>", name "<user> · sch|pcb", xsel}
- C++ (zero fork changes): pcbnew emits {uuids, fpPaths} (FOOTPRINT::GetPath)
and ghost-renders xsel via path-tail suffix scan; eeschema resolves xsel via
ResolveItem gated to the CURRENT sheet (xsel arrives project-wide, unlike
room-scoped selections); ghostStyle = alphas × xselAlphaScale (0.55, tuner-
patchable); new exports kicadCollabGetSelectionFull / TestGetCrossMapped /
TestSelectComponent (skips power symbols — PWR_FLAG has no footprint) +
merged-image dispatch
- tests: presence suites extended (payload shape, ghost render pixel tests,
13/13) + new two-tab tests/web/cross-probe.spec.ts (passing vs real
partykit); eeschema pixel compares now target the #glcanvas-* GAL panel
(the whole-window #canvas compare flaked on the auto-dismissing version
infobar — also fixes the long-known presence-eeschema restore flake);
cross-app + presence-kicad vitest suites
Spec: docs/features/collab-presence/0006 (closed repo).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lg5jwWuhFH5dL8hEcBDuP2
2026-07-07 19:30:18 +02:00
|
|
|
// The footprint's schematic link (0006): its (path …) ends in the symbol uuid.
|
|
|
|
|
const SYM1 = "aaaaaaaa-0000-0000-0000-000000000001";
|
|
|
|
|
const FP1_PATH = `/${SYM1}`;
|
e2e/CI: dual-engine suites, per-engine screenshots, SwiftShader retired, prod web suite, CI-coverage gate
Squash of experiment/ff-big-modules vs main.
Big-module routing removed: native-EH shrank kicad_editor below
SpiderMonkey's x86-64 code budget (runs 29355049705/29356152413 green on
stock Firefox), so BIG_MODULE_SPECS routing and the baseline-only-JIT
crutch are gone — kicad-firefox and kicad-chromium both run the full
suite, with the module compiled the way real users' browsers compile it.
Per-engine screenshots end to end: stableShot/shotPath write
test-results/<engine>/<name>.png; baselines move to
baseline-screenshots/{chromium,firefox}/ and the whole tools/screenshots
pipeline (compare/promote/manifest/spec-map/changelog/Discord) keys on
<engine>/<name>. Previously Firefox and Chromium renders of one spec
overwrote each other and Firefox renders were never actually gated.
Seeded from CI run 29421380806 (92 new firefox baselines, +24 chromium
web-suite shots); manifest generated from the baseline tree.
One merged playwright.config.ts (kicad/asyncify/coroutine/perf as
projects); ~25 dead npm scripts dropped. The web suite is gated in CI for
the first time ever (4 rotted specs fixed, 5 broken lib-bridge specs
triaged as fixme in docs/features/web-e2e-rot/); cheap lint step after
npm ci; last 26 blind-sleep violations fixed.
SwiftShader retired: CI Chromium renders WebGL on ANGLE → Mesa llvmpipe
(--use-gl=angle --use-angle=gl --ignore-gpu-blocklist; the blocklist flag
is mandatory — llvmpipe is blocklisted and WebGL is silently unavailable
without it) in BOTH configs. Under WORKERS=4 congestion SwiftShader
transiently failed the first post-board-load draw and the recovery
cascade ended in a silent permanent Cairo fallback — that engine flip was
the "~1.2% changedRatio both directions" occ-export baseline flake.
Validated 160/160 across two 80-repeat rigs; full analysis in
docs/features/wx-parity-bugs/occ-export-context-eviction.md. Chromium
baselines shift slightly on llvmpipe — promote once from the first green
run. Deflakes the new coverage exposed: presence baselines settle before
capture; presence fixtures declare current file formats; perf gets its
own outputDir so CI evidence survives; occ-export settles the board paint
before the export dialog; menu-item waits (waitForRenderedByLabel before
clickMenuItem) in 4 specs + the TESTING.md rule.
Web suite runs the PROD build, in parallel: webServer becomes backend
`start` + the standalone's e2e:preview (build-preview.mjs: link-wasm →
stash the public/wasm symlink aside during vite build, build-demo.mjs's
move — then vite preview as the persistent server). The wasm middleware
serves /wasm/* in preview and emits COOP/COEP/CORP itself (a pthread
worker script's own response must carry COEP or Chrome kills it with
ERR_BLOCKED_BY_RESPONSE). VITE_* flags bake at build time;
VITE_ALLOW_USER_OVERRIDE joins turbo globalEnv. fullyParallel + default
workers: 5.2m → 1.4m. Determinism fixes the parallel run exposed:
shared-page specs become serial groups; locks.spec grabs alice's exact
item via the new kicadCollabTestSelectByUuid hook (cross-tab "first
footprint" order is not a ysync invariant); quit specs poll page.url()
(quit supersedes its own navigation — NS_BINDING_ABORTED on Firefox).
Suite: 51 passed / 12 skipped / 0 failed in 1.6m.
CI-coverage gate (lint:ci-coverage): every tests/**/*.spec.ts must be
reachable from the npm scripts the workflows invoke — scraped from
.github/workflows/, resolved through package.json, coverage asked from
playwright --list itself. Rules: uncovered-spec + orphan-project (with a
documented LOCAL_ONLY_PROJECTS allowlist). Gating next to
lint:determinism; 138 spec files / 13 projects accounted for.
Product fixes kept from the investigations (reachable on real GPUs too):
wx 7799fd1be5 — paint flags clear before dispatch + Invalidate always
propagates; kicad 3dcfea5e45 — SwiftShader pass-boundary flush +
per-instance font texture + first-frame GL-error drain (GAL recovery
recovers instead of falling back to Cairo) + the user-facing eeschema
switch navigates again under __EMSCRIPTEN__ (project-sync's
FaceRegistered gate had rerouted it into the hidden sync player; caught
by the newly-gated web suite).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018eUxiPApHgGiu9NFyQfhAq
2026-07-17 12:10:40 +02:00
|
|
|
// version must be the CURRENT board format (pcb_io_kicad_sexpr.h): an older
|
|
|
|
|
// one makes pcbnew show the "created by an older version" wxInfoBar, whose
|
|
|
|
|
// appearance relayouts the GL panel at a load-dependent moment — permanently
|
|
|
|
|
// breaking the overlay tests' before/after pixel equality.
|
2026-07-06 15:59:51 +02:00
|
|
|
const SAMPLE_PCB = `(kicad_pcb
|
e2e/CI: dual-engine suites, per-engine screenshots, SwiftShader retired, prod web suite, CI-coverage gate
Squash of experiment/ff-big-modules vs main.
Big-module routing removed: native-EH shrank kicad_editor below
SpiderMonkey's x86-64 code budget (runs 29355049705/29356152413 green on
stock Firefox), so BIG_MODULE_SPECS routing and the baseline-only-JIT
crutch are gone — kicad-firefox and kicad-chromium both run the full
suite, with the module compiled the way real users' browsers compile it.
Per-engine screenshots end to end: stableShot/shotPath write
test-results/<engine>/<name>.png; baselines move to
baseline-screenshots/{chromium,firefox}/ and the whole tools/screenshots
pipeline (compare/promote/manifest/spec-map/changelog/Discord) keys on
<engine>/<name>. Previously Firefox and Chromium renders of one spec
overwrote each other and Firefox renders were never actually gated.
Seeded from CI run 29421380806 (92 new firefox baselines, +24 chromium
web-suite shots); manifest generated from the baseline tree.
One merged playwright.config.ts (kicad/asyncify/coroutine/perf as
projects); ~25 dead npm scripts dropped. The web suite is gated in CI for
the first time ever (4 rotted specs fixed, 5 broken lib-bridge specs
triaged as fixme in docs/features/web-e2e-rot/); cheap lint step after
npm ci; last 26 blind-sleep violations fixed.
SwiftShader retired: CI Chromium renders WebGL on ANGLE → Mesa llvmpipe
(--use-gl=angle --use-angle=gl --ignore-gpu-blocklist; the blocklist flag
is mandatory — llvmpipe is blocklisted and WebGL is silently unavailable
without it) in BOTH configs. Under WORKERS=4 congestion SwiftShader
transiently failed the first post-board-load draw and the recovery
cascade ended in a silent permanent Cairo fallback — that engine flip was
the "~1.2% changedRatio both directions" occ-export baseline flake.
Validated 160/160 across two 80-repeat rigs; full analysis in
docs/features/wx-parity-bugs/occ-export-context-eviction.md. Chromium
baselines shift slightly on llvmpipe — promote once from the first green
run. Deflakes the new coverage exposed: presence baselines settle before
capture; presence fixtures declare current file formats; perf gets its
own outputDir so CI evidence survives; occ-export settles the board paint
before the export dialog; menu-item waits (waitForRenderedByLabel before
clickMenuItem) in 4 specs + the TESTING.md rule.
Web suite runs the PROD build, in parallel: webServer becomes backend
`start` + the standalone's e2e:preview (build-preview.mjs: link-wasm →
stash the public/wasm symlink aside during vite build, build-demo.mjs's
move — then vite preview as the persistent server). The wasm middleware
serves /wasm/* in preview and emits COOP/COEP/CORP itself (a pthread
worker script's own response must carry COEP or Chrome kills it with
ERR_BLOCKED_BY_RESPONSE). VITE_* flags bake at build time;
VITE_ALLOW_USER_OVERRIDE joins turbo globalEnv. fullyParallel + default
workers: 5.2m → 1.4m. Determinism fixes the parallel run exposed:
shared-page specs become serial groups; locks.spec grabs alice's exact
item via the new kicadCollabTestSelectByUuid hook (cross-tab "first
footprint" order is not a ysync invariant); quit specs poll page.url()
(quit supersedes its own navigation — NS_BINDING_ABORTED on Firefox).
Suite: 51 passed / 12 skipped / 0 failed in 1.6m.
CI-coverage gate (lint:ci-coverage): every tests/**/*.spec.ts must be
reachable from the npm scripts the workflows invoke — scraped from
.github/workflows/, resolved through package.json, coverage asked from
playwright --list itself. Rules: uncovered-spec + orphan-project (with a
documented LOCAL_ONLY_PROJECTS allowlist). Gating next to
lint:determinism; 138 spec files / 13 projects accounted for.
Product fixes kept from the investigations (reachable on real GPUs too):
wx 7799fd1be5 — paint flags clear before dispatch + Invalidate always
propagates; kicad 3dcfea5e45 — SwiftShader pass-boundary flush +
per-instance font texture + first-frame GL-error drain (GAL recovery
recovers instead of falling back to Cairo) + the user-facing eeschema
switch navigates again under __EMSCRIPTEN__ (project-sync's
FaceRegistered gate had rerouted it into the hidden sync player; caught
by the newly-gated web suite).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018eUxiPApHgGiu9NFyQfhAq
2026-07-17 12:10:40 +02:00
|
|
|
\t(version 20260206)
|
2026-07-06 15:59:51 +02:00
|
|
|
\t(generator "pcbnew")
|
|
|
|
|
\t(generator_version "9.0")
|
|
|
|
|
\t(general
|
|
|
|
|
\t\t(thickness 1.6)
|
|
|
|
|
\t)
|
|
|
|
|
\t(paper "A4")
|
|
|
|
|
\t(layers
|
|
|
|
|
\t\t(0 "F.Cu" signal)
|
|
|
|
|
\t\t(2 "B.Cu" signal)
|
|
|
|
|
\t\t(37 "F.SilkS" user)
|
|
|
|
|
\t\t(25 "Edge.Cuts" user)
|
|
|
|
|
\t)
|
|
|
|
|
\t(setup)
|
|
|
|
|
\t(net 0 "")
|
|
|
|
|
\t(footprint "TestLib:R"
|
|
|
|
|
\t\t(layer "F.Cu")
|
|
|
|
|
\t\t(uuid "${FP1}")
|
|
|
|
|
\t\t(at 100 100)
|
feat(collab): cross-app selection — eeschema symbol ⇄ pcbnew footprint ghost highlight (collab-presence 0006)
Selecting a symbol in eeschema ghost-highlights the linked footprint(s) in
every pcbnew tab of the project, and vice versa — across users AND one
user's own two tabs. Native KIWAY cross-probe is inert in WASM (one frame
per page); this rides the presence layer instead.
- cross-app.ts: project-wide awareness-only room (presenceRoomId), publishes
full PresenceState at selection rate (cursor always null); peers() = other-
TOOL clients incl. own user's other tabs; window.__pcbjamCrossApp test handle
- presence-kicad.ts: parseSelectionEmit (bare array | {uuids,fpPaths}),
xselFromPeerState (pcbnew paths → symbol uuids; eeschema uuids verbatim),
cross peers appended to the kicadCollabSetRemote snapshot as
{id "<user>#x<client>", name "<user> · sch|pcb", xsel}
- C++ (zero fork changes): pcbnew emits {uuids, fpPaths} (FOOTPRINT::GetPath)
and ghost-renders xsel via path-tail suffix scan; eeschema resolves xsel via
ResolveItem gated to the CURRENT sheet (xsel arrives project-wide, unlike
room-scoped selections); ghostStyle = alphas × xselAlphaScale (0.55, tuner-
patchable); new exports kicadCollabGetSelectionFull / TestGetCrossMapped /
TestSelectComponent (skips power symbols — PWR_FLAG has no footprint) +
merged-image dispatch
- tests: presence suites extended (payload shape, ghost render pixel tests,
13/13) + new two-tab tests/web/cross-probe.spec.ts (passing vs real
partykit); eeschema pixel compares now target the #glcanvas-* GAL panel
(the whole-window #canvas compare flaked on the auto-dismissing version
infobar — also fixes the long-known presence-eeschema restore flake);
cross-app + presence-kicad vitest suites
Spec: docs/features/collab-presence/0006 (closed repo).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lg5jwWuhFH5dL8hEcBDuP2
2026-07-07 19:30:18 +02:00
|
|
|
\t\t(path "${FP1_PATH}")
|
2026-07-06 15:59:51 +02:00
|
|
|
\t\t(attr smd)
|
|
|
|
|
\t\t(property "Reference" "R1"
|
|
|
|
|
\t\t\t(at 0 -4.2 0)
|
|
|
|
|
\t\t\t(layer "F.SilkS")
|
|
|
|
|
\t\t\t(uuid "66666666-0000-0000-0000-0000000000aa")
|
|
|
|
|
\t\t\t(effects (font (size 1 1) (thickness 0.15)))
|
|
|
|
|
\t\t)
|
|
|
|
|
\t\t(property "Value" "R"
|
|
|
|
|
\t\t\t(at 0 4.6 0)
|
|
|
|
|
\t\t\t(layer "F.Fab")
|
|
|
|
|
\t\t\t(uuid "66666666-0000-0000-0000-0000000000bb")
|
|
|
|
|
\t\t\t(effects (font (size 1 1) (thickness 0.15)))
|
|
|
|
|
\t\t)
|
|
|
|
|
\t\t(pad "1" smd rect
|
|
|
|
|
\t\t\t(at -1 0)
|
|
|
|
|
\t\t\t(size 1 1)
|
|
|
|
|
\t\t\t(layers "F.Cu")
|
|
|
|
|
\t\t\t(uuid "66666666-0000-0000-0000-0000000000dd")
|
|
|
|
|
\t\t)
|
|
|
|
|
\t)
|
|
|
|
|
\t(segment (start 50.8 50.8) (end 101.6 50.8) (width 0.2) (layer "F.Cu") (net 0) (uuid "${SEG1}"))
|
|
|
|
|
)
|
|
|
|
|
`;
|
|
|
|
|
|
|
|
|
|
type FS = { mkdirTree(p: string): void; writeFile(p: string, d: string): void };
|
|
|
|
|
type Mod = {
|
|
|
|
|
kicadOpenFile(p: string): unknown;
|
|
|
|
|
kicadCollabPresenceStart(): void;
|
|
|
|
|
kicadCollabSetRemote(j: string): void;
|
|
|
|
|
kicadCollabGetViewport(): string;
|
|
|
|
|
kicadCollabGetSelection(): string;
|
feat(collab): cross-app selection — eeschema symbol ⇄ pcbnew footprint ghost highlight (collab-presence 0006)
Selecting a symbol in eeschema ghost-highlights the linked footprint(s) in
every pcbnew tab of the project, and vice versa — across users AND one
user's own two tabs. Native KIWAY cross-probe is inert in WASM (one frame
per page); this rides the presence layer instead.
- cross-app.ts: project-wide awareness-only room (presenceRoomId), publishes
full PresenceState at selection rate (cursor always null); peers() = other-
TOOL clients incl. own user's other tabs; window.__pcbjamCrossApp test handle
- presence-kicad.ts: parseSelectionEmit (bare array | {uuids,fpPaths}),
xselFromPeerState (pcbnew paths → symbol uuids; eeschema uuids verbatim),
cross peers appended to the kicadCollabSetRemote snapshot as
{id "<user>#x<client>", name "<user> · sch|pcb", xsel}
- C++ (zero fork changes): pcbnew emits {uuids, fpPaths} (FOOTPRINT::GetPath)
and ghost-renders xsel via path-tail suffix scan; eeschema resolves xsel via
ResolveItem gated to the CURRENT sheet (xsel arrives project-wide, unlike
room-scoped selections); ghostStyle = alphas × xselAlphaScale (0.55, tuner-
patchable); new exports kicadCollabGetSelectionFull / TestGetCrossMapped /
TestSelectComponent (skips power symbols — PWR_FLAG has no footprint) +
merged-image dispatch
- tests: presence suites extended (payload shape, ghost render pixel tests,
13/13) + new two-tab tests/web/cross-probe.spec.ts (passing vs real
partykit); eeschema pixel compares now target the #glcanvas-* GAL panel
(the whole-window #canvas compare flaked on the auto-dismissing version
infobar — also fixes the long-known presence-eeschema restore flake);
cross-app + presence-kicad vitest suites
Spec: docs/features/collab-presence/0006 (closed repo).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lg5jwWuhFH5dL8hEcBDuP2
2026-07-07 19:30:18 +02:00
|
|
|
kicadCollabGetSelectionFull(): string;
|
|
|
|
|
kicadCollabTestGetCrossMapped(): string;
|
2026-07-06 15:59:51 +02:00
|
|
|
kicadCollabTestSelectFirst(): string;
|
|
|
|
|
kicadCollabTestClearSelection(): boolean;
|
|
|
|
|
};
|
feat(collab): cross-app selection — eeschema symbol ⇄ pcbnew footprint ghost highlight (collab-presence 0006)
Selecting a symbol in eeschema ghost-highlights the linked footprint(s) in
every pcbnew tab of the project, and vice versa — across users AND one
user's own two tabs. Native KIWAY cross-probe is inert in WASM (one frame
per page); this rides the presence layer instead.
- cross-app.ts: project-wide awareness-only room (presenceRoomId), publishes
full PresenceState at selection rate (cursor always null); peers() = other-
TOOL clients incl. own user's other tabs; window.__pcbjamCrossApp test handle
- presence-kicad.ts: parseSelectionEmit (bare array | {uuids,fpPaths}),
xselFromPeerState (pcbnew paths → symbol uuids; eeschema uuids verbatim),
cross peers appended to the kicadCollabSetRemote snapshot as
{id "<user>#x<client>", name "<user> · sch|pcb", xsel}
- C++ (zero fork changes): pcbnew emits {uuids, fpPaths} (FOOTPRINT::GetPath)
and ghost-renders xsel via path-tail suffix scan; eeschema resolves xsel via
ResolveItem gated to the CURRENT sheet (xsel arrives project-wide, unlike
room-scoped selections); ghostStyle = alphas × xselAlphaScale (0.55, tuner-
patchable); new exports kicadCollabGetSelectionFull / TestGetCrossMapped /
TestSelectComponent (skips power symbols — PWR_FLAG has no footprint) +
merged-image dispatch
- tests: presence suites extended (payload shape, ghost render pixel tests,
13/13) + new two-tab tests/web/cross-probe.spec.ts (passing vs real
partykit); eeschema pixel compares now target the #glcanvas-* GAL panel
(the whole-window #canvas compare flaked on the auto-dismissing version
infobar — also fixes the long-known presence-eeschema restore flake);
cross-app + presence-kicad vitest suites
Spec: docs/features/collab-presence/0006 (closed repo).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lg5jwWuhFH5dL8hEcBDuP2
2026-07-07 19:30:18 +02:00
|
|
|
type SelPayload = { uuids: string[]; fpPaths: string[] };
|
2026-07-06 15:59:51 +02:00
|
|
|
type PresenceWindow = {
|
|
|
|
|
FS: FS;
|
|
|
|
|
Module: Mod;
|
|
|
|
|
kicadCollab?: Record<string, unknown>;
|
|
|
|
|
__selEmits?: string[][];
|
feat(collab): cross-app selection — eeschema symbol ⇄ pcbnew footprint ghost highlight (collab-presence 0006)
Selecting a symbol in eeschema ghost-highlights the linked footprint(s) in
every pcbnew tab of the project, and vice versa — across users AND one
user's own two tabs. Native KIWAY cross-probe is inert in WASM (one frame
per page); this rides the presence layer instead.
- cross-app.ts: project-wide awareness-only room (presenceRoomId), publishes
full PresenceState at selection rate (cursor always null); peers() = other-
TOOL clients incl. own user's other tabs; window.__pcbjamCrossApp test handle
- presence-kicad.ts: parseSelectionEmit (bare array | {uuids,fpPaths}),
xselFromPeerState (pcbnew paths → symbol uuids; eeschema uuids verbatim),
cross peers appended to the kicadCollabSetRemote snapshot as
{id "<user>#x<client>", name "<user> · sch|pcb", xsel}
- C++ (zero fork changes): pcbnew emits {uuids, fpPaths} (FOOTPRINT::GetPath)
and ghost-renders xsel via path-tail suffix scan; eeschema resolves xsel via
ResolveItem gated to the CURRENT sheet (xsel arrives project-wide, unlike
room-scoped selections); ghostStyle = alphas × xselAlphaScale (0.55, tuner-
patchable); new exports kicadCollabGetSelectionFull / TestGetCrossMapped /
TestSelectComponent (skips power symbols — PWR_FLAG has no footprint) +
merged-image dispatch
- tests: presence suites extended (payload shape, ghost render pixel tests,
13/13) + new two-tab tests/web/cross-probe.spec.ts (passing vs real
partykit); eeschema pixel compares now target the #glcanvas-* GAL panel
(the whole-window #canvas compare flaked on the auto-dismissing version
infobar — also fixes the long-known presence-eeschema restore flake);
cross-app + presence-kicad vitest suites
Spec: docs/features/collab-presence/0006 (closed repo).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lg5jwWuhFH5dL8hEcBDuP2
2026-07-07 19:30:18 +02:00
|
|
|
__selPayloads?: SelPayload[];
|
2026-07-06 15:59:51 +02:00
|
|
|
__cursorEmits?: Array<{ x: number; y: number; active: number }>;
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
function hasAbort(l: { consoleLogs: string[]; errors: string[] }): boolean {
|
|
|
|
|
return [...l.consoleLogs, ...l.errors].some((s) => s.includes("Aborted("));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
async function bootAndOpen(page: Page): Promise<void> {
|
|
|
|
|
await page.goto("/kicad/pcbnew-collab.html");
|
|
|
|
|
await expect(page.locator("#canvas")).toBeVisible({ timeout: 90000 });
|
|
|
|
|
await page.waitForFunction(() => !!window.wxElementRegistry, null, { timeout: 90000 });
|
|
|
|
|
await page.waitForFunction(
|
|
|
|
|
() => {
|
|
|
|
|
const m = (window as unknown as { Module?: Partial<Mod> }).Module;
|
|
|
|
|
return (
|
|
|
|
|
typeof m?.kicadOpenFile === "function" &&
|
|
|
|
|
typeof m?.kicadCollabSetRemote === "function" &&
|
|
|
|
|
typeof m?.kicadCollabTestSelectFirst === "function"
|
|
|
|
|
);
|
|
|
|
|
},
|
|
|
|
|
null,
|
|
|
|
|
{ timeout: 90000 },
|
|
|
|
|
);
|
|
|
|
|
await page.waitForFunction(
|
|
|
|
|
() =>
|
|
|
|
|
!!window.wxElementRegistry &&
|
|
|
|
|
window.wxElementRegistry
|
|
|
|
|
.findAll({ visible: true })
|
|
|
|
|
.some((e) => /Frame$/.test(e.typeName) || (e.name || "").endsWith("Frame")),
|
|
|
|
|
null,
|
|
|
|
|
{ timeout: 90000 },
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
await page.evaluate(
|
|
|
|
|
({ content }) => {
|
|
|
|
|
const w = window as unknown as PresenceWindow;
|
|
|
|
|
const dir = "/home/kicad/documents";
|
|
|
|
|
try {
|
|
|
|
|
w.FS.mkdirTree(dir);
|
|
|
|
|
} catch {
|
|
|
|
|
/* exists */
|
|
|
|
|
}
|
|
|
|
|
const p = `${dir}/presence.kicad_pcb`;
|
|
|
|
|
w.FS.writeFile(p, content);
|
|
|
|
|
w.Module.kicadOpenFile(p);
|
|
|
|
|
},
|
|
|
|
|
{ content: SAMPLE_PCB },
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
// Board open settles asynchronously; wait for the title to carry the file stem.
|
|
|
|
|
await expect
|
|
|
|
|
.poll(() => page.title(), { timeout: 60000, intervals: [500] })
|
|
|
|
|
.toMatch(/presence/i);
|
|
|
|
|
|
feat(collab): cross-app selection — eeschema symbol ⇄ pcbnew footprint ghost highlight (collab-presence 0006)
Selecting a symbol in eeschema ghost-highlights the linked footprint(s) in
every pcbnew tab of the project, and vice versa — across users AND one
user's own two tabs. Native KIWAY cross-probe is inert in WASM (one frame
per page); this rides the presence layer instead.
- cross-app.ts: project-wide awareness-only room (presenceRoomId), publishes
full PresenceState at selection rate (cursor always null); peers() = other-
TOOL clients incl. own user's other tabs; window.__pcbjamCrossApp test handle
- presence-kicad.ts: parseSelectionEmit (bare array | {uuids,fpPaths}),
xselFromPeerState (pcbnew paths → symbol uuids; eeschema uuids verbatim),
cross peers appended to the kicadCollabSetRemote snapshot as
{id "<user>#x<client>", name "<user> · sch|pcb", xsel}
- C++ (zero fork changes): pcbnew emits {uuids, fpPaths} (FOOTPRINT::GetPath)
and ghost-renders xsel via path-tail suffix scan; eeschema resolves xsel via
ResolveItem gated to the CURRENT sheet (xsel arrives project-wide, unlike
room-scoped selections); ghostStyle = alphas × xselAlphaScale (0.55, tuner-
patchable); new exports kicadCollabGetSelectionFull / TestGetCrossMapped /
TestSelectComponent (skips power symbols — PWR_FLAG has no footprint) +
merged-image dispatch
- tests: presence suites extended (payload shape, ghost render pixel tests,
13/13) + new two-tab tests/web/cross-probe.spec.ts (passing vs real
partykit); eeschema pixel compares now target the #glcanvas-* GAL panel
(the whole-window #canvas compare flaked on the auto-dismissing version
infobar — also fixes the long-known presence-eeschema restore flake);
cross-app + presence-kicad vitest suites
Spec: docs/features/collab-presence/0006 (closed repo).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lg5jwWuhFH5dL8hEcBDuP2
2026-07-07 19:30:18 +02:00
|
|
|
// Install the capture hooks + start the presence input bindings. Since 0006
|
|
|
|
|
// pcbnew emits `{uuids, fpPaths}` — capture the uuid arrays (the pre-0006
|
|
|
|
|
// assertions) AND the full payloads (the cross-app ones).
|
2026-07-06 15:59:51 +02:00
|
|
|
await page.evaluate(() => {
|
|
|
|
|
const w = window as unknown as PresenceWindow;
|
|
|
|
|
w.__selEmits = [];
|
feat(collab): cross-app selection — eeschema symbol ⇄ pcbnew footprint ghost highlight (collab-presence 0006)
Selecting a symbol in eeschema ghost-highlights the linked footprint(s) in
every pcbnew tab of the project, and vice versa — across users AND one
user's own two tabs. Native KIWAY cross-probe is inert in WASM (one frame
per page); this rides the presence layer instead.
- cross-app.ts: project-wide awareness-only room (presenceRoomId), publishes
full PresenceState at selection rate (cursor always null); peers() = other-
TOOL clients incl. own user's other tabs; window.__pcbjamCrossApp test handle
- presence-kicad.ts: parseSelectionEmit (bare array | {uuids,fpPaths}),
xselFromPeerState (pcbnew paths → symbol uuids; eeschema uuids verbatim),
cross peers appended to the kicadCollabSetRemote snapshot as
{id "<user>#x<client>", name "<user> · sch|pcb", xsel}
- C++ (zero fork changes): pcbnew emits {uuids, fpPaths} (FOOTPRINT::GetPath)
and ghost-renders xsel via path-tail suffix scan; eeschema resolves xsel via
ResolveItem gated to the CURRENT sheet (xsel arrives project-wide, unlike
room-scoped selections); ghostStyle = alphas × xselAlphaScale (0.55, tuner-
patchable); new exports kicadCollabGetSelectionFull / TestGetCrossMapped /
TestSelectComponent (skips power symbols — PWR_FLAG has no footprint) +
merged-image dispatch
- tests: presence suites extended (payload shape, ghost render pixel tests,
13/13) + new two-tab tests/web/cross-probe.spec.ts (passing vs real
partykit); eeschema pixel compares now target the #glcanvas-* GAL panel
(the whole-window #canvas compare flaked on the auto-dismissing version
infobar — also fixes the long-known presence-eeschema restore flake);
cross-app + presence-kicad vitest suites
Spec: docs/features/collab-presence/0006 (closed repo).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lg5jwWuhFH5dL8hEcBDuP2
2026-07-07 19:30:18 +02:00
|
|
|
w.__selPayloads = [];
|
2026-07-06 15:59:51 +02:00
|
|
|
w.__cursorEmits = [];
|
|
|
|
|
w.kicadCollab = {
|
|
|
|
|
...w.kicadCollab,
|
feat(collab): cross-app selection — eeschema symbol ⇄ pcbnew footprint ghost highlight (collab-presence 0006)
Selecting a symbol in eeschema ghost-highlights the linked footprint(s) in
every pcbnew tab of the project, and vice versa — across users AND one
user's own two tabs. Native KIWAY cross-probe is inert in WASM (one frame
per page); this rides the presence layer instead.
- cross-app.ts: project-wide awareness-only room (presenceRoomId), publishes
full PresenceState at selection rate (cursor always null); peers() = other-
TOOL clients incl. own user's other tabs; window.__pcbjamCrossApp test handle
- presence-kicad.ts: parseSelectionEmit (bare array | {uuids,fpPaths}),
xselFromPeerState (pcbnew paths → symbol uuids; eeschema uuids verbatim),
cross peers appended to the kicadCollabSetRemote snapshot as
{id "<user>#x<client>", name "<user> · sch|pcb", xsel}
- C++ (zero fork changes): pcbnew emits {uuids, fpPaths} (FOOTPRINT::GetPath)
and ghost-renders xsel via path-tail suffix scan; eeschema resolves xsel via
ResolveItem gated to the CURRENT sheet (xsel arrives project-wide, unlike
room-scoped selections); ghostStyle = alphas × xselAlphaScale (0.55, tuner-
patchable); new exports kicadCollabGetSelectionFull / TestGetCrossMapped /
TestSelectComponent (skips power symbols — PWR_FLAG has no footprint) +
merged-image dispatch
- tests: presence suites extended (payload shape, ghost render pixel tests,
13/13) + new two-tab tests/web/cross-probe.spec.ts (passing vs real
partykit); eeschema pixel compares now target the #glcanvas-* GAL panel
(the whole-window #canvas compare flaked on the auto-dismissing version
infobar — also fixes the long-known presence-eeschema restore flake);
cross-app + presence-kicad vitest suites
Spec: docs/features/collab-presence/0006 (closed repo).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lg5jwWuhFH5dL8hEcBDuP2
2026-07-07 19:30:18 +02:00
|
|
|
onSelection: (json: string) => {
|
|
|
|
|
const parsed = JSON.parse(json) as SelPayload | string[];
|
|
|
|
|
const payload: SelPayload = Array.isArray(parsed)
|
|
|
|
|
? { uuids: parsed, fpPaths: [] }
|
|
|
|
|
: parsed;
|
|
|
|
|
w.__selEmits!.push(payload.uuids);
|
|
|
|
|
w.__selPayloads!.push(payload);
|
|
|
|
|
},
|
2026-07-06 15:59:51 +02:00
|
|
|
onCursor: (x: number, y: number, active: number) =>
|
|
|
|
|
w.__cursorEmits!.push({ x, y, active }),
|
|
|
|
|
};
|
|
|
|
|
w.Module.kicadCollabPresenceStart();
|
|
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
test("selection emit: programmatic select/clear reaches onSelection with uuids", async ({
|
|
|
|
|
page,
|
|
|
|
|
testLogger,
|
|
|
|
|
}) => {
|
|
|
|
|
await bootAndOpen(page);
|
|
|
|
|
|
|
|
|
|
const selectedId = await page.evaluate(() =>
|
|
|
|
|
(window as unknown as PresenceWindow).Module.kicadCollabTestSelectFirst(),
|
|
|
|
|
);
|
|
|
|
|
expect(selectedId).toBeTruthy();
|
|
|
|
|
|
|
|
|
|
await expect
|
|
|
|
|
.poll(
|
|
|
|
|
() =>
|
|
|
|
|
page.evaluate(() => {
|
|
|
|
|
const w = window as unknown as PresenceWindow;
|
|
|
|
|
return w.__selEmits!.at(-1) ?? null;
|
|
|
|
|
}),
|
|
|
|
|
{ timeout: 10000 },
|
|
|
|
|
)
|
|
|
|
|
.toEqual([selectedId]);
|
|
|
|
|
|
|
|
|
|
await page.evaluate(() =>
|
|
|
|
|
(window as unknown as PresenceWindow).Module.kicadCollabTestClearSelection(),
|
|
|
|
|
);
|
|
|
|
|
await expect
|
|
|
|
|
.poll(
|
|
|
|
|
() =>
|
|
|
|
|
page.evaluate(() => {
|
|
|
|
|
const w = window as unknown as PresenceWindow;
|
|
|
|
|
return w.__selEmits!.at(-1) ?? null;
|
|
|
|
|
}),
|
|
|
|
|
{ timeout: 10000 },
|
|
|
|
|
)
|
|
|
|
|
.toEqual([]);
|
|
|
|
|
|
|
|
|
|
expect(hasAbort(testLogger)).toBe(false);
|
|
|
|
|
});
|
|
|
|
|
|
feat(collab): cross-app selection — eeschema symbol ⇄ pcbnew footprint ghost highlight (collab-presence 0006)
Selecting a symbol in eeschema ghost-highlights the linked footprint(s) in
every pcbnew tab of the project, and vice versa — across users AND one
user's own two tabs. Native KIWAY cross-probe is inert in WASM (one frame
per page); this rides the presence layer instead.
- cross-app.ts: project-wide awareness-only room (presenceRoomId), publishes
full PresenceState at selection rate (cursor always null); peers() = other-
TOOL clients incl. own user's other tabs; window.__pcbjamCrossApp test handle
- presence-kicad.ts: parseSelectionEmit (bare array | {uuids,fpPaths}),
xselFromPeerState (pcbnew paths → symbol uuids; eeschema uuids verbatim),
cross peers appended to the kicadCollabSetRemote snapshot as
{id "<user>#x<client>", name "<user> · sch|pcb", xsel}
- C++ (zero fork changes): pcbnew emits {uuids, fpPaths} (FOOTPRINT::GetPath)
and ghost-renders xsel via path-tail suffix scan; eeschema resolves xsel via
ResolveItem gated to the CURRENT sheet (xsel arrives project-wide, unlike
room-scoped selections); ghostStyle = alphas × xselAlphaScale (0.55, tuner-
patchable); new exports kicadCollabGetSelectionFull / TestGetCrossMapped /
TestSelectComponent (skips power symbols — PWR_FLAG has no footprint) +
merged-image dispatch
- tests: presence suites extended (payload shape, ghost render pixel tests,
13/13) + new two-tab tests/web/cross-probe.spec.ts (passing vs real
partykit); eeschema pixel compares now target the #glcanvas-* GAL panel
(the whole-window #canvas compare flaked on the auto-dismissing version
infobar — also fixes the long-known presence-eeschema restore flake);
cross-app + presence-kicad vitest suites
Spec: docs/features/collab-presence/0006 (closed repo).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lg5jwWuhFH5dL8hEcBDuP2
2026-07-07 19:30:18 +02:00
|
|
|
test("selection emit carries the footprint's schematic path (0006)", async ({
|
|
|
|
|
page,
|
|
|
|
|
testLogger,
|
|
|
|
|
}) => {
|
|
|
|
|
await bootAndOpen(page);
|
|
|
|
|
|
|
|
|
|
// TestSelectFirst picks the first top-level item — the fixture's only
|
|
|
|
|
// footprint sorts first, but assert by payload rather than by luck: select,
|
|
|
|
|
// then find the emit whose uuids contain the footprint.
|
|
|
|
|
await page.evaluate(() =>
|
|
|
|
|
(window as unknown as PresenceWindow).Module.kicadCollabTestSelectFirst(),
|
|
|
|
|
);
|
|
|
|
|
await expect
|
|
|
|
|
.poll(
|
|
|
|
|
() =>
|
|
|
|
|
page.evaluate(() => {
|
|
|
|
|
const w = window as unknown as PresenceWindow;
|
|
|
|
|
return w.__selPayloads!.at(-1) ?? null;
|
|
|
|
|
}),
|
|
|
|
|
{ timeout: 10000 },
|
|
|
|
|
)
|
|
|
|
|
.not.toBeNull();
|
|
|
|
|
|
|
|
|
|
const payload = await page.evaluate(
|
|
|
|
|
() => (window as unknown as PresenceWindow).__selPayloads!.at(-1)!,
|
|
|
|
|
);
|
|
|
|
|
if (payload.uuids.includes(FP1)) {
|
|
|
|
|
expect(payload.fpPaths).toEqual([FP1_PATH]);
|
|
|
|
|
} else {
|
|
|
|
|
// A non-footprint got selected first — the paths list must then be empty.
|
|
|
|
|
expect(payload.fpPaths).toEqual([]);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// The pull export mirrors the emit payload (cross-app seed at attach).
|
|
|
|
|
const full = await page.evaluate(() =>
|
|
|
|
|
JSON.parse((window as unknown as PresenceWindow).Module.kicadCollabGetSelectionFull()),
|
|
|
|
|
);
|
|
|
|
|
expect(full.uuids).toEqual(payload.uuids);
|
|
|
|
|
expect(full.fpPaths).toEqual(payload.fpPaths);
|
|
|
|
|
|
|
|
|
|
expect(hasAbort(testLogger)).toBe(false);
|
|
|
|
|
});
|
|
|
|
|
|
2026-07-06 15:59:51 +02:00
|
|
|
test("selection emit: a real canvas click drives the wx-layer trigger", async ({
|
|
|
|
|
page,
|
|
|
|
|
testLogger,
|
|
|
|
|
}) => {
|
|
|
|
|
await bootAndOpen(page);
|
|
|
|
|
|
|
|
|
|
// Rubber-band box-select across the sheet: `#canvas` is the WHOLE wx app
|
|
|
|
|
// window (menus/toolbars included) — the GAL draw panel is its own DOM element
|
|
|
|
|
// (`#glcanvas-*`, see zoom-cursor.spec.ts). A drag over most of the panel
|
|
|
|
|
// catches the board items without depending on exact world→screen math; the
|
|
|
|
|
// closing LEFT_UP is the wx-layer trigger under test.
|
|
|
|
|
const glId = await page.evaluate(() => {
|
|
|
|
|
const visible = Array.from(document.querySelectorAll('[id^="glcanvas-"]'))
|
|
|
|
|
.map((c) => c as HTMLCanvasElement)
|
|
|
|
|
.find((c) => {
|
|
|
|
|
const rect = c.getBoundingClientRect();
|
|
|
|
|
return window.getComputedStyle(c).display !== "none" && rect.width > 0;
|
|
|
|
|
});
|
|
|
|
|
return visible?.id ?? null;
|
|
|
|
|
});
|
|
|
|
|
expect(glId).toBeTruthy();
|
|
|
|
|
const box = await page.locator(`#${glId}`).boundingBox();
|
|
|
|
|
expect(box).toBeTruthy();
|
|
|
|
|
|
|
|
|
|
const x0 = box!.x + box!.width * 0.1;
|
|
|
|
|
const y0 = box!.y + box!.height * 0.1;
|
|
|
|
|
const x1 = box!.x + box!.width * 0.9;
|
|
|
|
|
const y1 = box!.y + box!.height * 0.9;
|
|
|
|
|
|
|
|
|
|
await page.mouse.move(x0, y0);
|
|
|
|
|
await page.mouse.down();
|
|
|
|
|
await page.mouse.move(x1, y1, { steps: 8 });
|
|
|
|
|
await page.mouse.up();
|
|
|
|
|
|
|
|
|
|
// First check the selection actually happened (separates "the drag didn't
|
|
|
|
|
// select" from "the emit trigger is broken").
|
|
|
|
|
await expect
|
|
|
|
|
.poll(
|
|
|
|
|
() =>
|
|
|
|
|
page.evaluate(() =>
|
|
|
|
|
JSON.parse(
|
|
|
|
|
(window as unknown as PresenceWindow).Module.kicadCollabGetSelection(),
|
|
|
|
|
).length,
|
|
|
|
|
),
|
|
|
|
|
{ timeout: 10000, message: "box-select never selected anything" },
|
|
|
|
|
)
|
|
|
|
|
.toBeGreaterThan(0);
|
|
|
|
|
|
|
|
|
|
await expect
|
|
|
|
|
.poll(
|
|
|
|
|
() =>
|
|
|
|
|
page.evaluate(() => {
|
|
|
|
|
const w = window as unknown as PresenceWindow;
|
|
|
|
|
return w.__selEmits!.some((s) => s.length > 0);
|
|
|
|
|
}),
|
|
|
|
|
{ timeout: 10000, message: "selection happened but onSelection never emitted" },
|
|
|
|
|
)
|
|
|
|
|
.toBe(true);
|
|
|
|
|
|
|
|
|
|
expect(hasAbort(testLogger)).toBe(false);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
test("cursor emit: mouse motion over the canvas produces throttled world coords", async ({
|
|
|
|
|
page,
|
|
|
|
|
testLogger,
|
|
|
|
|
}) => {
|
|
|
|
|
await bootAndOpen(page);
|
|
|
|
|
|
|
|
|
|
const canvas = page.locator("#canvas");
|
|
|
|
|
const box = await canvas.boundingBox();
|
|
|
|
|
expect(box).toBeTruthy();
|
|
|
|
|
|
|
|
|
|
// Sweep the pointer across the canvas center with many small steps.
|
|
|
|
|
const cx = box!.x + box!.width / 2;
|
|
|
|
|
const cy = box!.y + box!.height / 2;
|
2026-07-08 12:19:25 +02:00
|
|
|
const sweepStart = Date.now();
|
2026-07-06 15:59:51 +02:00
|
|
|
for (let i = 0; i < 30; i++) {
|
|
|
|
|
await page.mouse.move(cx - 150 + i * 10, cy, { steps: 1 });
|
|
|
|
|
}
|
2026-07-08 12:19:25 +02:00
|
|
|
const sweepMs = Date.now() - sweepStart;
|
2026-07-06 15:59:51 +02:00
|
|
|
|
|
|
|
|
const emits = await page.evaluate(
|
|
|
|
|
() => (window as unknown as PresenceWindow).__cursorEmits!,
|
|
|
|
|
);
|
|
|
|
|
expect(emits.length).toBeGreaterThan(0);
|
2026-07-08 12:19:25 +02:00
|
|
|
// Throttle is 50 ms (≤20 Hz). On a slow runner the awaited moves themselves
|
|
|
|
|
// can straddle throttle windows, so bound by measured sweep duration rather
|
|
|
|
|
// than a fixed count: one emit per 50 ms window, +1 leading edge, +2 slack.
|
|
|
|
|
expect(emits.length).toBeLessThanOrEqual(Math.floor(sweepMs / 50) + 3);
|
2026-07-06 15:59:51 +02:00
|
|
|
|
|
|
|
|
const active = emits.filter((e) => e.active === 1);
|
|
|
|
|
expect(active.length).toBeGreaterThan(0);
|
|
|
|
|
// World coords: an A4 board view centers around 10^8 nm — sanity-band check.
|
|
|
|
|
for (const e of active) {
|
|
|
|
|
expect(Math.abs(e.x)).toBeLessThan(1e10);
|
|
|
|
|
expect(Math.abs(e.y)).toBeLessThan(1e10);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
expect(hasAbort(testLogger)).toBe(false);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
test("remote render paints the overlay without touching local selection", async ({
|
|
|
|
|
page,
|
|
|
|
|
testLogger,
|
|
|
|
|
}) => {
|
|
|
|
|
await bootAndOpen(page);
|
|
|
|
|
|
|
|
|
|
const canvas = page.locator("#canvas");
|
e2e/CI: dual-engine suites, per-engine screenshots, SwiftShader retired, prod web suite, CI-coverage gate
Squash of experiment/ff-big-modules vs main.
Big-module routing removed: native-EH shrank kicad_editor below
SpiderMonkey's x86-64 code budget (runs 29355049705/29356152413 green on
stock Firefox), so BIG_MODULE_SPECS routing and the baseline-only-JIT
crutch are gone — kicad-firefox and kicad-chromium both run the full
suite, with the module compiled the way real users' browsers compile it.
Per-engine screenshots end to end: stableShot/shotPath write
test-results/<engine>/<name>.png; baselines move to
baseline-screenshots/{chromium,firefox}/ and the whole tools/screenshots
pipeline (compare/promote/manifest/spec-map/changelog/Discord) keys on
<engine>/<name>. Previously Firefox and Chromium renders of one spec
overwrote each other and Firefox renders were never actually gated.
Seeded from CI run 29421380806 (92 new firefox baselines, +24 chromium
web-suite shots); manifest generated from the baseline tree.
One merged playwright.config.ts (kicad/asyncify/coroutine/perf as
projects); ~25 dead npm scripts dropped. The web suite is gated in CI for
the first time ever (4 rotted specs fixed, 5 broken lib-bridge specs
triaged as fixme in docs/features/web-e2e-rot/); cheap lint step after
npm ci; last 26 blind-sleep violations fixed.
SwiftShader retired: CI Chromium renders WebGL on ANGLE → Mesa llvmpipe
(--use-gl=angle --use-angle=gl --ignore-gpu-blocklist; the blocklist flag
is mandatory — llvmpipe is blocklisted and WebGL is silently unavailable
without it) in BOTH configs. Under WORKERS=4 congestion SwiftShader
transiently failed the first post-board-load draw and the recovery
cascade ended in a silent permanent Cairo fallback — that engine flip was
the "~1.2% changedRatio both directions" occ-export baseline flake.
Validated 160/160 across two 80-repeat rigs; full analysis in
docs/features/wx-parity-bugs/occ-export-context-eviction.md. Chromium
baselines shift slightly on llvmpipe — promote once from the first green
run. Deflakes the new coverage exposed: presence baselines settle before
capture; presence fixtures declare current file formats; perf gets its
own outputDir so CI evidence survives; occ-export settles the board paint
before the export dialog; menu-item waits (waitForRenderedByLabel before
clickMenuItem) in 4 specs + the TESTING.md rule.
Web suite runs the PROD build, in parallel: webServer becomes backend
`start` + the standalone's e2e:preview (build-preview.mjs: link-wasm →
stash the public/wasm symlink aside during vite build, build-demo.mjs's
move — then vite preview as the persistent server). The wasm middleware
serves /wasm/* in preview and emits COOP/COEP/CORP itself (a pthread
worker script's own response must carry COEP or Chrome kills it with
ERR_BLOCKED_BY_RESPONSE). VITE_* flags bake at build time;
VITE_ALLOW_USER_OVERRIDE joins turbo globalEnv. fullyParallel + default
workers: 5.2m → 1.4m. Determinism fixes the parallel run exposed:
shared-page specs become serial groups; locks.spec grabs alice's exact
item via the new kicadCollabTestSelectByUuid hook (cross-tab "first
footprint" order is not a ysync invariant); quit specs poll page.url()
(quit supersedes its own navigation — NS_BINDING_ABORTED on Firefox).
Suite: 51 passed / 12 skipped / 0 failed in 1.6m.
CI-coverage gate (lint:ci-coverage): every tests/**/*.spec.ts must be
reachable from the npm scripts the workflows invoke — scraped from
.github/workflows/, resolved through package.json, coverage asked from
playwright --list itself. Rules: uncovered-spec + orphan-project (with a
documented LOCAL_ONLY_PROJECTS allowlist). Gating next to
lint:determinism; 138 spec files / 13 projects accounted for.
Product fixes kept from the investigations (reachable on real GPUs too):
wx 7799fd1be5 — paint flags clear before dispatch + Invalidate always
propagates; kicad 3dcfea5e45 — SwiftShader pass-boundary flush +
per-instance font texture + first-frame GL-error drain (GAL recovery
recovers instead of falling back to Cairo) + the user-facing eeschema
switch navigates again under __EMSCRIPTEN__ (project-sync's
FaceRegistered gate had rerouted it into the hidden sync player; caught
by the newly-gated web suite).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018eUxiPApHgGiu9NFyQfhAq
2026-07-17 12:10:40 +02:00
|
|
|
const before = await settledShot(canvas);
|
2026-07-06 15:59:51 +02:00
|
|
|
|
|
|
|
|
await page.evaluate(
|
|
|
|
|
({ fp }) => {
|
|
|
|
|
const w = window as unknown as PresenceWindow;
|
|
|
|
|
w.Module.kicadCollabSetRemote(
|
|
|
|
|
JSON.stringify({
|
|
|
|
|
peers: [
|
|
|
|
|
{
|
|
|
|
|
id: "bob",
|
|
|
|
|
name: "bob",
|
|
|
|
|
color: "#ef4444",
|
|
|
|
|
cursor: { x: 90e6, y: 90e6 },
|
|
|
|
|
selection: [fp],
|
|
|
|
|
},
|
|
|
|
|
],
|
|
|
|
|
}),
|
|
|
|
|
);
|
|
|
|
|
},
|
|
|
|
|
{ fp: FP1 },
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
// The overlay redraw runs via CallAfter + coroutine; poll the pixels.
|
|
|
|
|
await expect
|
|
|
|
|
.poll(
|
|
|
|
|
async () => {
|
|
|
|
|
const after = await canvas.screenshot();
|
|
|
|
|
return !after.equals(before);
|
|
|
|
|
},
|
|
|
|
|
{ timeout: 15000, intervals: [500] },
|
|
|
|
|
)
|
|
|
|
|
.toBe(true);
|
|
|
|
|
|
|
|
|
|
// No state leak: the remote render never enters the local selection.
|
|
|
|
|
const localSel = await page.evaluate(() =>
|
|
|
|
|
JSON.parse(
|
|
|
|
|
(window as unknown as PresenceWindow).Module.kicadCollabGetSelection(),
|
|
|
|
|
),
|
|
|
|
|
);
|
|
|
|
|
expect(localSel).toEqual([]);
|
|
|
|
|
|
|
|
|
|
// Clearing the peers restores the original pixels.
|
|
|
|
|
await page.evaluate(() =>
|
|
|
|
|
(window as unknown as PresenceWindow).Module.kicadCollabSetRemote(
|
|
|
|
|
JSON.stringify({ peers: [] }),
|
|
|
|
|
),
|
|
|
|
|
);
|
|
|
|
|
await expect
|
|
|
|
|
.poll(
|
|
|
|
|
async () => {
|
|
|
|
|
const after = await canvas.screenshot();
|
|
|
|
|
return after.equals(before);
|
|
|
|
|
},
|
|
|
|
|
{ timeout: 15000, intervals: [500] },
|
|
|
|
|
)
|
|
|
|
|
.toBe(true);
|
|
|
|
|
|
|
|
|
|
expect(hasAbort(testLogger)).toBe(false);
|
|
|
|
|
});
|
|
|
|
|
|
feat(collab): cross-app selection — eeschema symbol ⇄ pcbnew footprint ghost highlight (collab-presence 0006)
Selecting a symbol in eeschema ghost-highlights the linked footprint(s) in
every pcbnew tab of the project, and vice versa — across users AND one
user's own two tabs. Native KIWAY cross-probe is inert in WASM (one frame
per page); this rides the presence layer instead.
- cross-app.ts: project-wide awareness-only room (presenceRoomId), publishes
full PresenceState at selection rate (cursor always null); peers() = other-
TOOL clients incl. own user's other tabs; window.__pcbjamCrossApp test handle
- presence-kicad.ts: parseSelectionEmit (bare array | {uuids,fpPaths}),
xselFromPeerState (pcbnew paths → symbol uuids; eeschema uuids verbatim),
cross peers appended to the kicadCollabSetRemote snapshot as
{id "<user>#x<client>", name "<user> · sch|pcb", xsel}
- C++ (zero fork changes): pcbnew emits {uuids, fpPaths} (FOOTPRINT::GetPath)
and ghost-renders xsel via path-tail suffix scan; eeschema resolves xsel via
ResolveItem gated to the CURRENT sheet (xsel arrives project-wide, unlike
room-scoped selections); ghostStyle = alphas × xselAlphaScale (0.55, tuner-
patchable); new exports kicadCollabGetSelectionFull / TestGetCrossMapped /
TestSelectComponent (skips power symbols — PWR_FLAG has no footprint) +
merged-image dispatch
- tests: presence suites extended (payload shape, ghost render pixel tests,
13/13) + new two-tab tests/web/cross-probe.spec.ts (passing vs real
partykit); eeschema pixel compares now target the #glcanvas-* GAL panel
(the whole-window #canvas compare flaked on the auto-dismissing version
infobar — also fixes the long-known presence-eeschema restore flake);
cross-app + presence-kicad vitest suites
Spec: docs/features/collab-presence/0006 (closed repo).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lg5jwWuhFH5dL8hEcBDuP2
2026-07-07 19:30:18 +02:00
|
|
|
test("cross-app ghost render: an eeschema peer's symbol uuid maps to the footprint (0006)", async ({
|
|
|
|
|
page,
|
|
|
|
|
testLogger,
|
|
|
|
|
}) => {
|
|
|
|
|
await bootAndOpen(page);
|
|
|
|
|
|
|
|
|
|
const canvas = page.locator("#canvas");
|
e2e/CI: dual-engine suites, per-engine screenshots, SwiftShader retired, prod web suite, CI-coverage gate
Squash of experiment/ff-big-modules vs main.
Big-module routing removed: native-EH shrank kicad_editor below
SpiderMonkey's x86-64 code budget (runs 29355049705/29356152413 green on
stock Firefox), so BIG_MODULE_SPECS routing and the baseline-only-JIT
crutch are gone — kicad-firefox and kicad-chromium both run the full
suite, with the module compiled the way real users' browsers compile it.
Per-engine screenshots end to end: stableShot/shotPath write
test-results/<engine>/<name>.png; baselines move to
baseline-screenshots/{chromium,firefox}/ and the whole tools/screenshots
pipeline (compare/promote/manifest/spec-map/changelog/Discord) keys on
<engine>/<name>. Previously Firefox and Chromium renders of one spec
overwrote each other and Firefox renders were never actually gated.
Seeded from CI run 29421380806 (92 new firefox baselines, +24 chromium
web-suite shots); manifest generated from the baseline tree.
One merged playwright.config.ts (kicad/asyncify/coroutine/perf as
projects); ~25 dead npm scripts dropped. The web suite is gated in CI for
the first time ever (4 rotted specs fixed, 5 broken lib-bridge specs
triaged as fixme in docs/features/web-e2e-rot/); cheap lint step after
npm ci; last 26 blind-sleep violations fixed.
SwiftShader retired: CI Chromium renders WebGL on ANGLE → Mesa llvmpipe
(--use-gl=angle --use-angle=gl --ignore-gpu-blocklist; the blocklist flag
is mandatory — llvmpipe is blocklisted and WebGL is silently unavailable
without it) in BOTH configs. Under WORKERS=4 congestion SwiftShader
transiently failed the first post-board-load draw and the recovery
cascade ended in a silent permanent Cairo fallback — that engine flip was
the "~1.2% changedRatio both directions" occ-export baseline flake.
Validated 160/160 across two 80-repeat rigs; full analysis in
docs/features/wx-parity-bugs/occ-export-context-eviction.md. Chromium
baselines shift slightly on llvmpipe — promote once from the first green
run. Deflakes the new coverage exposed: presence baselines settle before
capture; presence fixtures declare current file formats; perf gets its
own outputDir so CI evidence survives; occ-export settles the board paint
before the export dialog; menu-item waits (waitForRenderedByLabel before
clickMenuItem) in 4 specs + the TESTING.md rule.
Web suite runs the PROD build, in parallel: webServer becomes backend
`start` + the standalone's e2e:preview (build-preview.mjs: link-wasm →
stash the public/wasm symlink aside during vite build, build-demo.mjs's
move — then vite preview as the persistent server). The wasm middleware
serves /wasm/* in preview and emits COOP/COEP/CORP itself (a pthread
worker script's own response must carry COEP or Chrome kills it with
ERR_BLOCKED_BY_RESPONSE). VITE_* flags bake at build time;
VITE_ALLOW_USER_OVERRIDE joins turbo globalEnv. fullyParallel + default
workers: 5.2m → 1.4m. Determinism fixes the parallel run exposed:
shared-page specs become serial groups; locks.spec grabs alice's exact
item via the new kicadCollabTestSelectByUuid hook (cross-tab "first
footprint" order is not a ysync invariant); quit specs poll page.url()
(quit supersedes its own navigation — NS_BINDING_ABORTED on Firefox).
Suite: 51 passed / 12 skipped / 0 failed in 1.6m.
CI-coverage gate (lint:ci-coverage): every tests/**/*.spec.ts must be
reachable from the npm scripts the workflows invoke — scraped from
.github/workflows/, resolved through package.json, coverage asked from
playwright --list itself. Rules: uncovered-spec + orphan-project (with a
documented LOCAL_ONLY_PROJECTS allowlist). Gating next to
lint:determinism; 138 spec files / 13 projects accounted for.
Product fixes kept from the investigations (reachable on real GPUs too):
wx 7799fd1be5 — paint flags clear before dispatch + Invalidate always
propagates; kicad 3dcfea5e45 — SwiftShader pass-boundary flush +
per-instance font texture + first-frame GL-error drain (GAL recovery
recovers instead of falling back to Cairo) + the user-facing eeschema
switch navigates again under __EMSCRIPTEN__ (project-sync's
FaceRegistered gate had rerouted it into the hidden sync player; caught
by the newly-gated web suite).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018eUxiPApHgGiu9NFyQfhAq
2026-07-17 12:10:40 +02:00
|
|
|
const before = await settledShot(canvas);
|
feat(collab): cross-app selection — eeschema symbol ⇄ pcbnew footprint ghost highlight (collab-presence 0006)
Selecting a symbol in eeschema ghost-highlights the linked footprint(s) in
every pcbnew tab of the project, and vice versa — across users AND one
user's own two tabs. Native KIWAY cross-probe is inert in WASM (one frame
per page); this rides the presence layer instead.
- cross-app.ts: project-wide awareness-only room (presenceRoomId), publishes
full PresenceState at selection rate (cursor always null); peers() = other-
TOOL clients incl. own user's other tabs; window.__pcbjamCrossApp test handle
- presence-kicad.ts: parseSelectionEmit (bare array | {uuids,fpPaths}),
xselFromPeerState (pcbnew paths → symbol uuids; eeschema uuids verbatim),
cross peers appended to the kicadCollabSetRemote snapshot as
{id "<user>#x<client>", name "<user> · sch|pcb", xsel}
- C++ (zero fork changes): pcbnew emits {uuids, fpPaths} (FOOTPRINT::GetPath)
and ghost-renders xsel via path-tail suffix scan; eeschema resolves xsel via
ResolveItem gated to the CURRENT sheet (xsel arrives project-wide, unlike
room-scoped selections); ghostStyle = alphas × xselAlphaScale (0.55, tuner-
patchable); new exports kicadCollabGetSelectionFull / TestGetCrossMapped /
TestSelectComponent (skips power symbols — PWR_FLAG has no footprint) +
merged-image dispatch
- tests: presence suites extended (payload shape, ghost render pixel tests,
13/13) + new two-tab tests/web/cross-probe.spec.ts (passing vs real
partykit); eeschema pixel compares now target the #glcanvas-* GAL panel
(the whole-window #canvas compare flaked on the auto-dismissing version
infobar — also fixes the long-known presence-eeschema restore flake);
cross-app + presence-kicad vitest suites
Spec: docs/features/collab-presence/0006 (closed repo).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lg5jwWuhFH5dL8hEcBDuP2
2026-07-07 19:30:18 +02:00
|
|
|
|
|
|
|
|
// An eeschema peer snapshot entry: no same-doc selection, xsel = symbol uuid.
|
|
|
|
|
await page.evaluate(
|
|
|
|
|
({ sym }) => {
|
|
|
|
|
const w = window as unknown as PresenceWindow;
|
|
|
|
|
w.Module.kicadCollabSetRemote(
|
|
|
|
|
JSON.stringify({
|
|
|
|
|
peers: [
|
|
|
|
|
{
|
|
|
|
|
id: "bob#x7",
|
|
|
|
|
name: "bob · sch",
|
|
|
|
|
color: "#d946ef",
|
|
|
|
|
cursor: null,
|
|
|
|
|
selection: [],
|
|
|
|
|
xsel: [sym],
|
|
|
|
|
},
|
|
|
|
|
],
|
|
|
|
|
}),
|
|
|
|
|
);
|
|
|
|
|
},
|
|
|
|
|
{ sym: SYM1 },
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
// The suffix match resolves the symbol to the fixture footprint.
|
|
|
|
|
await expect
|
|
|
|
|
.poll(
|
|
|
|
|
() =>
|
|
|
|
|
page.evaluate(() =>
|
|
|
|
|
JSON.parse(
|
|
|
|
|
(window as unknown as PresenceWindow).Module.kicadCollabTestGetCrossMapped(),
|
|
|
|
|
),
|
|
|
|
|
),
|
|
|
|
|
{ timeout: 10000 },
|
|
|
|
|
)
|
|
|
|
|
.toEqual([FP1]);
|
|
|
|
|
|
|
|
|
|
// …and paints the ghost outline (pixels change), with no selection leak.
|
|
|
|
|
await expect
|
|
|
|
|
.poll(
|
|
|
|
|
async () => !(await canvas.screenshot()).equals(before),
|
|
|
|
|
{ timeout: 15000, intervals: [500] },
|
|
|
|
|
)
|
|
|
|
|
.toBe(true);
|
|
|
|
|
const localSel = await page.evaluate(() =>
|
|
|
|
|
JSON.parse((window as unknown as PresenceWindow).Module.kicadCollabGetSelection()),
|
|
|
|
|
);
|
|
|
|
|
expect(localSel).toEqual([]);
|
|
|
|
|
|
|
|
|
|
// An unknown symbol uuid maps to nothing; clearing restores the pixels.
|
|
|
|
|
await page.evaluate(() => {
|
|
|
|
|
const w = window as unknown as PresenceWindow;
|
|
|
|
|
w.Module.kicadCollabSetRemote(
|
|
|
|
|
JSON.stringify({
|
|
|
|
|
peers: [
|
|
|
|
|
{
|
|
|
|
|
id: "bob#x7",
|
|
|
|
|
name: "bob · sch",
|
|
|
|
|
color: "#d946ef",
|
|
|
|
|
cursor: null,
|
|
|
|
|
selection: [],
|
|
|
|
|
xsel: ["99999999-0000-0000-0000-000000000099"],
|
|
|
|
|
},
|
|
|
|
|
],
|
|
|
|
|
}),
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
await expect
|
|
|
|
|
.poll(
|
|
|
|
|
() =>
|
|
|
|
|
page.evaluate(() =>
|
|
|
|
|
JSON.parse(
|
|
|
|
|
(window as unknown as PresenceWindow).Module.kicadCollabTestGetCrossMapped(),
|
|
|
|
|
),
|
|
|
|
|
),
|
|
|
|
|
{ timeout: 10000 },
|
|
|
|
|
)
|
|
|
|
|
.toEqual([]);
|
|
|
|
|
|
|
|
|
|
await page.evaluate(() =>
|
|
|
|
|
(window as unknown as PresenceWindow).Module.kicadCollabSetRemote(
|
|
|
|
|
JSON.stringify({ peers: [] }),
|
|
|
|
|
),
|
|
|
|
|
);
|
|
|
|
|
await expect
|
|
|
|
|
.poll(
|
|
|
|
|
async () => (await canvas.screenshot()).equals(before),
|
|
|
|
|
{ timeout: 15000, intervals: [500] },
|
|
|
|
|
)
|
|
|
|
|
.toBe(true);
|
|
|
|
|
|
|
|
|
|
expect(hasAbort(testLogger)).toBe(false);
|
|
|
|
|
});
|
|
|
|
|
|
feat(collab): follow-user (collab-presence 0008) + chip depth-layer fix
Follow-user: click a peer's roster avatar to mirror their viewport until
local input breaks it.
- collab_presence_core.h: CORE::fitViewport(cx, cy, halfW, halfH) — fit the
leader's world rect with CONTAIN semantics (zoom derived from the
follower's own canvas via the ToScreen ratio; GetScale is the zoom, not
px/IU). Exported as kicadCollabFitViewport from both editor TUs + the
merged dispatcher.
- presence-kicad.ts: publish the visible world rect (viewportRect) into
awareness, 100 ms trailing throttle; guarded for pre-0008 handles.
- follow-user.ts: createFollow — follows an awareness CLIENT (a tab, not a
user); applies leader rect changes via FitViewport, dedupes unchanged
republishes; break-on-interact compares local onViewport echoes against
the last applied rect (2% rel tolerance, echo-grace before the first fit
lands); unfollows on leader-left; pauses on eeschema sheet mismatch.
- PresenceRoster: avatars are follow toggles (ring on the followed peer);
WasmTool renders the "Following <name> — move to stop" banner.
- tests: 7 controller units (85/85 collab), fitViewport round-trip e2e in
both kicad presence specs (20/20), two-tab tests/web/follow.spec.ts
(converge → track → wheel-zoom breaks → subsequent moves ignored).
Chip depth-layer fix (user-reported): name chips washed out inside
low-alpha selection fills — chip rects shared the shapes overlay's single
depth, and same-depth fragments drawn LATER lose the depth test, so an
earlier-painted fill rejected the chip's pixels. Now three layers via the
fork's VIEW_OVERLAY::SetDepthOffset: text (0) < chips + pin dots (1) <
selection shapes (2). drawLabel/drawCursor/drawSelectionBox take the chip
overlay explicitly; comment-pin dots move to the chip layer too (the 0005
"drawn last so pins sit above" comment had the rule backwards). Verified
with a chip-inside-30%-fill pixel repro + the full presence suite.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013u9h8fkQktH7KRECaHJmUG
2026-07-09 09:30:40 +02:00
|
|
|
// Follow-user (0008): FitViewport applies a world rect with contain semantics —
|
|
|
|
|
// verified through the GetViewport round trip (center lands, the contained
|
|
|
|
|
// axis' half-extent matches the request within the fit's own tolerance).
|
|
|
|
|
test("fitViewport applies a world rect (contain) — GetViewport round trip", async ({
|
|
|
|
|
page,
|
|
|
|
|
testLogger,
|
|
|
|
|
}) => {
|
|
|
|
|
await bootAndOpen(page);
|
|
|
|
|
|
|
|
|
|
const target = { cx: 120e6, cy: 90e6, halfW: 40e6, halfH: 30e6 };
|
|
|
|
|
await page.evaluate((t) => {
|
|
|
|
|
const m = (window as unknown as PresenceWindow).Module as unknown as {
|
|
|
|
|
kicadCollabFitViewport(cx: number, cy: number, hw: number, hh: number): void;
|
|
|
|
|
};
|
|
|
|
|
m.kicadCollabFitViewport(t.cx, t.cy, t.halfW, t.halfH);
|
|
|
|
|
}, target);
|
|
|
|
|
|
jspi cleanup: remove the asyncify-era residue — dead code, conditionals, pipeline scaffolding, stale prose
The runtime is JSPI-only; this removes everything that still pretended
otherwise. Three exhaustive sweeps (C++/JS+build+CI/tests+docs) drove
the inventory; every deletion verified by grep closure + full gates.
Broken-right-now fixes:
- deploy-staging.yml passed the retired opt_level input — the workflow
could not even start. Removed.
- env.sh carried dead exports with a live -sASYNCIFY=1 inside
(WASM_LDFLAGS/PTHREAD_LDFLAGS, zero consumers). Removed; the
WASM_LEGACY_EXCEPTIONS rationale rewritten to the real reason.
- docker/build.sh exported PCBJAM_ASYNC_BACKEND (read nowhere). Gone.
Dead weight removed:
- binaryen submodule (nothing builds or invokes it), wasm-opt-bench
workflow + scripts/bench/, get-wasm-opt.sh, diagnostics.js (242 lines
of Asyncify-API-only code), the KICAD_PIPELINE background-postprocess
scaffolding (existed to parallelize the deleted wasm-opt phase; the
postprocess is a seconds-long node script and now runs inline),
build-monitor's dead asyncify rows, sched-context orphan build
output, dead .gitignore entries, the .jspi-assets spike dir (the two
wf-result research JSONs moved to docs/features/async/migration-evidence/).
- bindings: fiber_park.h + its 12 embind registrations (broken-if-
called under JSPI), the kicadOpenFileStart/OPEN_JOB starter route,
main_stack_runner.h + 5 includes, the always-null context-sleep weak
hook in nanosleep_yield.c.
- shim: the backend field (installed-flag idempotency instead),
noteContextWait (dead both sides), the __wxAsyncifyDump alias (+ the
WasmTool fallback and string-dump normalize branch).
- web: the emscripten-6-ignored mainScriptUrlOrBlob option in boot.ts
(gerber-demo keeps it: it loads the deployed CDN release, which
predates emscripten 6 — noted inline).
Conditionals: all 'backend === jspi' checks reduced to scheduler-
presence checks; races_quiescent re-keyed from Asyncify.state (vacuous)
to real backlog quiescence (resumeReady/mutatorQueue — NOT _windowLive,
which is the probing activation's own window by definition).
Renames (identifiers only, no file renames): ASYNC_LINK_FLAGS→
JSPI_LINK_FLAGS and Makefile ASYNC_LDFLAGS→JSPI_LDFLAGS,
kicadCollabFiberBusy→kicadCollabBusy (embind + web + tests),
collab_common.h fiber*→apply*/coroutine naming, asyncifySignatures→
wasmTrapSignatures (lists byte-identical).
Tests: the two remaining vacuous [wx-asyncify]/fiber-resume-refused
asserts re-keyed to live JSPI beacons; eeschema-load's failure message
no longer sends the developer to a deleted script; wait-beacons' dead
families/parser deleted; lane-0 legacy-glue guards removed (lane 0 is
unconstructible); the embind test.fail re-gated with the JSPI reason
(plain embind invokers cannot suspend — verified still failing);
lint-determinism now scans tests/jspi (166 files clean);
eeschema-collab local-move gated to chromium (~50% flaky on FF even
solo; pcbnew twin covers both engines).
Docs: DEBUG.md rewritten as the JSPI debugging guide; build.md
describes the single-phase build; docs/features/async/README.md
banner-marked historical and repointed at the NEW
23-jspi-runtime.md (current architecture: export census, turnstile,
libcontext ownership + refusal contract, embind call shapes, the
em-pthread service-wrapper trick, exception policy, known gaps).
Gates on the cleaned tree: test:e2e 725 passed / 0 failed (after the
quiescence-probe fix; the 3 other reds were verified contention flakes
solo-green or the documented FF gate), web 76/0, jspi 18/18 both
engines, vitest 295/295 + 17/17, all lints green, live-app census
clean.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016X9eh1s5sTx1o9Em9KBuwR
2026-08-14 09:25:32 +02:00
|
|
|
// The fit is CallAfter+coroutine scheduled — poll the transform until it lands.
|
feat(collab): follow-user (collab-presence 0008) + chip depth-layer fix
Follow-user: click a peer's roster avatar to mirror their viewport until
local input breaks it.
- collab_presence_core.h: CORE::fitViewport(cx, cy, halfW, halfH) — fit the
leader's world rect with CONTAIN semantics (zoom derived from the
follower's own canvas via the ToScreen ratio; GetScale is the zoom, not
px/IU). Exported as kicadCollabFitViewport from both editor TUs + the
merged dispatcher.
- presence-kicad.ts: publish the visible world rect (viewportRect) into
awareness, 100 ms trailing throttle; guarded for pre-0008 handles.
- follow-user.ts: createFollow — follows an awareness CLIENT (a tab, not a
user); applies leader rect changes via FitViewport, dedupes unchanged
republishes; break-on-interact compares local onViewport echoes against
the last applied rect (2% rel tolerance, echo-grace before the first fit
lands); unfollows on leader-left; pauses on eeschema sheet mismatch.
- PresenceRoster: avatars are follow toggles (ring on the followed peer);
WasmTool renders the "Following <name> — move to stop" banner.
- tests: 7 controller units (85/85 collab), fitViewport round-trip e2e in
both kicad presence specs (20/20), two-tab tests/web/follow.spec.ts
(converge → track → wheel-zoom breaks → subsequent moves ignored).
Chip depth-layer fix (user-reported): name chips washed out inside
low-alpha selection fills — chip rects shared the shapes overlay's single
depth, and same-depth fragments drawn LATER lose the depth test, so an
earlier-painted fill rejected the chip's pixels. Now three layers via the
fork's VIEW_OVERLAY::SetDepthOffset: text (0) < chips + pin dots (1) <
selection shapes (2). drawLabel/drawCursor/drawSelectionBox take the chip
overlay explicitly; comment-pin dots move to the chip layer too (the 0005
"drawn last so pins sit above" comment had the rule backwards). Verified
with a chip-inside-30%-fill pixel repro + the full presence suite.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013u9h8fkQktH7KRECaHJmUG
2026-07-09 09:30:40 +02:00
|
|
|
await expect
|
|
|
|
|
.poll(
|
|
|
|
|
async () => {
|
|
|
|
|
const vp = await page.evaluate(() =>
|
|
|
|
|
JSON.parse((window as unknown as PresenceWindow).Module.kicadCollabGetViewport()),
|
|
|
|
|
);
|
|
|
|
|
return Math.abs(vp.cx - target.cx) < 1e6 && Math.abs(vp.cy - target.cy) < 1e6;
|
|
|
|
|
},
|
|
|
|
|
{ timeout: 20000, intervals: [250] },
|
|
|
|
|
)
|
|
|
|
|
.toBe(true);
|
|
|
|
|
|
|
|
|
|
const vp = await page.evaluate(() =>
|
|
|
|
|
JSON.parse((window as unknown as PresenceWindow).Module.kicadCollabGetViewport()),
|
|
|
|
|
);
|
|
|
|
|
// Contain: at least one axis' visible half-extent matches the request (the
|
|
|
|
|
// other overshoots by the canvas aspect), and neither is SMALLER (cropping).
|
|
|
|
|
const halfW = vp.w / 2 / vp.scale;
|
|
|
|
|
const halfH = vp.h / 2 / vp.scale;
|
|
|
|
|
expect(halfW).toBeGreaterThan(target.halfW * 0.95);
|
|
|
|
|
expect(halfH).toBeGreaterThan(target.halfH * 0.95);
|
|
|
|
|
const relW = Math.abs(halfW - target.halfW) / target.halfW;
|
|
|
|
|
const relH = Math.abs(halfH - target.halfH) / target.halfH;
|
|
|
|
|
expect(Math.min(relW, relH)).toBeLessThan(0.05);
|
|
|
|
|
|
|
|
|
|
expect(hasAbort(testLogger)).toBe(false);
|
|
|
|
|
});
|
|
|
|
|
|
2026-07-06 15:59:51 +02:00
|
|
|
test("viewport export returns a sane world↔screen transform", async ({ page, testLogger }) => {
|
|
|
|
|
await bootAndOpen(page);
|
|
|
|
|
|
|
|
|
|
const vp = await page.evaluate(() =>
|
|
|
|
|
JSON.parse((window as unknown as PresenceWindow).Module.kicadCollabGetViewport()),
|
|
|
|
|
);
|
|
|
|
|
expect(vp.w).toBeGreaterThan(0);
|
|
|
|
|
expect(vp.h).toBeGreaterThan(0);
|
|
|
|
|
// scale must be px per IU (nm) THROUGH THE GAL MATRIX — VIEW::GetScale() is
|
|
|
|
|
// the zoom (O(1)), which once shipped here and made every screen-constant
|
|
|
|
|
// overlay size sub-nanometre. A framed A4 sheet is a few thousand px per
|
|
|
|
|
// 3e8 nm, so the true value is O(1e-5).
|
|
|
|
|
expect(vp.scale).toBeGreaterThan(0);
|
|
|
|
|
expect(vp.scale).toBeLessThan(0.01);
|
|
|
|
|
const worldWidthMm = vp.w / vp.scale / 1e6;
|
|
|
|
|
expect(worldWidthMm).toBeGreaterThan(50);
|
|
|
|
|
expect(worldWidthMm).toBeLessThan(3000);
|
|
|
|
|
// The opened A4 board frames around (148.5,105) mm — the center must be on-board.
|
|
|
|
|
expect(vp.cx).toBeGreaterThan(0);
|
|
|
|
|
expect(vp.cx).toBeLessThan(400e6);
|
|
|
|
|
expect(vp.cy).toBeGreaterThan(0);
|
|
|
|
|
expect(vp.cy).toBeLessThan(400e6);
|
|
|
|
|
|
|
|
|
|
expect(hasAbort(testLogger)).toBe(false);
|
|
|
|
|
});
|