From b5588adf06df069bee114a09902a0e4cf6d91e5d Mon Sep 17 00:00:00 2001 From: Stewart Allen Date: Wed, 7 Mar 2018 12:21:59 -0500 Subject: [PATCH] update notes --- js/geo-point.js | 7 +++++++ notes.md | 2 -- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/js/geo-point.js b/js/geo-point.js index d086a151..cbc4e7ca 100644 --- a/js/geo-point.js +++ b/js/geo-point.js @@ -142,6 +142,13 @@ var gs_base_point = exports; return Math.sqrt(this.distToLineSq(p1, p2)); }; + /** + * used exclusively in new fill code. output does not agree with + * old distToLine, but is the only method that seems to work for + * fill. using new distToLine as a global replacement breaks support + * offset clipping. both need to be investigated and a single line + * normal distance needs to be formulated to replace both functions. + */ PRO.distToLineNew = function(p1, p2) { return p2l(this, p1, p2); // return Math.sqrt(this.distToLineSq(p1, p2)); diff --git a/notes.md b/notes.md index 6ae9c1aa..cdcf2588 100644 --- a/notes.md +++ b/notes.md @@ -61,8 +61,6 @@ * trim support offset from layer below * feather sharp tips by reducing extrusion in area of overlap -* add option to reduce poly speed to match shortest/slowest segment - (helps when no k-factor support in firmware) * use fill spacing for top raft fill spacing * fix thin fill (outside). compute before sparse as separate logic. * fix wrong first point in general (all modes)