From 798ee85d234b1c0cd65e446a5efbeea16a6aa8a2 Mon Sep 17 00:00:00 2001
From: Stewart Allen <stewart.allen@gmail.com>
Date: Wed, 5 Oct 2022 12:22:53 -0400
Subject: [PATCH] add CAM pocket option to ignore interior features (outline
 only)

---
 release.md                  | 1 +
 src/kiri-mode/cam/client.js | 5 ++++-
 src/kiri-mode/cam/ops.js    | 6 ++++++
 src/kiri/conf.js            | 1 +
 web/kiri/lang/en.js         | 2 ++
 5 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/release.md b/release.md
index b3c637c6..e02287d8 100644
--- a/release.md
+++ b/release.md
@@ -17,6 +17,7 @@ Full docs @ https://docs.grid.space/projects/kiri-moto
 * add bridging option in CAM contouring
 * add option to force z max routing in CAM
 * add option to ignore z bottom in CAM contouring
+* add CAM pocket option to ignore interior features (outline only)
 * add CAM Z bottom visualization, make it relative to stock instead of part
 * extend url loading of workspaces to all formats
 * alert when healing is enabled and non-manifold geometries are detected
diff --git a/src/kiri-mode/cam/client.js b/src/kiri-mode/cam/client.js
index 5f2c9069..96cc5768 100644
--- a/src/kiri-mode/cam/client.js
+++ b/src/kiri-mode/cam/client.js
@@ -1067,7 +1067,8 @@ CAM.init = function(kiri, api) {
         down:    'camPocketDown',
         rate:    'camPocketSpeed',
         plunge:  'camPocketPlunge',
-        expand:  'camPocketExpand'
+        expand:  'camPocketExpand',
+        outline: 'cmaPocketOutline'
     }).inputs = {
         tool:     UC.newSelect(LANG.cc_tool, {}, "tools"),
         sep:      UC.newBlank({class:"pop-sep"}),
@@ -1076,7 +1077,9 @@ CAM.init = function(kiri, api) {
         down:     UC.newInput(LANG.cc_sdwn_s, {title:LANG.cc_sdwn_l, convert:UC.toFloat, units:true}),
         rate:     UC.newInput(LANG.cc_feed_s, {title:LANG.cc_feed_l, convert:UC.toInt, units:true}),
         plunge:   UC.newInput(LANG.cc_plng_s, {title:LANG.cc_plng_l, convert:UC.toInt, units:true}),
+        sep:      UC.newBlank({class:"pop-sep"}),
         expand:   UC.newInput(LANG.cp_xpnd_s, {title:LANG.cp_xpnd_l, convert:UC.toFloat, units:true}),
+        outline:  UC.newBoolean(LANG.cp_outl_s, undefined, {title:LANG.cp_outl_l}),
         sep:      UC.newBlank({class:"pop-sep"}),
         menu: UC.newRow([
             UC.newButton(undefined, func.surfaceAdd, {icon:'<i class="fas fa-plus"></i>'}),
diff --git a/src/kiri-mode/cam/ops.js b/src/kiri-mode/cam/ops.js
index a4c43c6a..6053283c 100644
--- a/src/kiri-mode/cam/ops.js
+++ b/src/kiri-mode/cam/ops.js
@@ -1027,6 +1027,12 @@ class OpPocket extends CamOp {
             if (outline.length === 0) {
                 continue;
             }
+            // option to skip interior features (holes, pillars)
+            if (op.outline) {
+                for (let p of outline) {
+                    p.inner = undefined;
+                }
+            }
             if (false) newSliceOut(zmin).output()
                 .setLayer("pocket area", {line: 0x1188ff}, false)
                 .addPolys(outline)
diff --git a/src/kiri/conf.js b/src/kiri/conf.js
index 82c079d3..a726bec1 100644
--- a/src/kiri/conf.js
+++ b/src/kiri/conf.js
@@ -507,6 +507,7 @@ const conf = exports({
                 camPocketSpeed: 250,
                 camPocketPlunge: 200,
                 camPocketExpand: 0,
+                cmaPocketOutline: false,
                 camDrillTool: 1000,
                 camDrillSpindle: 1000,
                 camDrillDownSpeed: 250,
diff --git a/web/kiri/lang/en.js b/web/kiri/lang/en.js
index c0f687c7..2cd32728 100644
--- a/web/kiri/lang/en.js
+++ b/web/kiri/lang/en.js
@@ -512,6 +512,8 @@ self.kiri.lang['en-us'] = {
     // CNC POCKET
     cp_xpnd_s:      "expand",
     cp_xpnd_l:      ["grow selected area to","encompass corners"],
+    cp_outl_s:      "outline only",
+    cp_outl_l:      ["ignore interior voids and features"],
 
     // CNC DRILLING
     cd_menu:        "drill",