cad-editor/src/app/update
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Hakan Seven cb41910f12 fix: address review findings on merged #293/#292 hatch+snap
Three defects found reviewing the just-merged PRs:

- PLOTWINDOW forced corner snap (#293) only ran in the on_tick preview
  path, so the marker highlighted an endpoint but the click committed a
  plain snap — with the global OSNAP master (or Endpoint mode) off the
  corner landed at the raw cursor, defeating the feature. Apply the same
  snap_forced_corners branch at the click-commit recompute.

- build_dxf_pattern (#292) wrote the pattern line's LOCAL step into the
  world-frame HatchPatternLine.offset. The new prebaked reader
  inverse-rotates offset assuming world frame, so app-created hatches
  (HATCH command) collapsed their spacing by cos(angle) — ANSI31 at 45deg
  rendered 2.245 instead of 3.175 on both viewport and PDF/plot export.
  Rotate the local step into world here so it round-trips and the stored
  offset is format-correct for other CAD apps.

- far_from_origin_pattern_hatch_still_fills placed its offset ALONG the
  45deg lines (projects to k~0), so it never exercised the span-cap fix and
  passed even with the old absolute-index clamp restored. Move the offset
  perpendicular to the lines so |k| >> the cap. Add
  app_created_hatch_roundtrips_catalog_spacing to guard the offset-frame
  fix (verified: fails at 2.245 without it, passes at 3.175 with it).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-06 20:23:59 +03:00
..
command.rs feat(plugin): surface loaded plugin commands in command-line autocomplete 2026-07-04 23:01:53 +03:00
dialog.rs feat(ribbon): collapse overflowing panels to flyout buttons, anchor dropdowns to their widget 2026-07-05 18:04:55 +03:00
dynamic.rs fix(dynin): read a comma-separated second point as cartesian, not W/H 2026-07-04 22:27:59 +03:00
file.rs chore: post-merge cleanup for #287/#289 2026-07-06 01:22:10 +03:00
mod.rs Merge PR #287: plot a model-space window to PDF 2026-07-06 01:17:03 +03:00
style.rs refactor(viewport): migrate model-space tiling to iced pane_grid 2026-06-27 11:50:11 +03:00
util.rs refactor: split four oversized files into submodule trees 2026-06-26 22:51:29 +03:00
viewport.rs fix: address review findings on merged #293/#292 hatch+snap 2026-07-06 20:23:59 +03:00