AI_Assistant/cad-editor
Watch
1
0
Fork
You've already forked cad-editor
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(command-line): uppercase only the command verb, not arguments

Browse source 
submit() uppercased the entire typed line, mangling case-sensitive arguments
(file paths on case-sensitive filesystems, identifiers, plugin command args) on
Linux/macOS. Uppercase only the first token; verbs still match and each
sub-command handler already re-uppercases its own keywords.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Hakan Seven 2026-06-16 04:46:27 +03:00
commit eff6c7c730
1 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/ui/command_line.rs
View file

@ -73,13 +73,21 @@ impl CommandLine {
}
pub fn submit(&mut self) -> Option<String> {
let cmd = self.input.trim().to_uppercase();
if cmd.is_empty() {
let raw = self.input.trim().to_string();
if raw.is_empty() {
return None;
}
// Uppercase only the command verb (the first token); keep arguments
// verbatim so case-sensitive values survive — file paths on
// case-sensitive filesystems, identifiers, plugin command arguments.
// Dispatch matches verbs in uppercase and each sub-command handler
// re-uppercases its own keywords, so only free-form args are affected.
let cmd = match raw.split_once(char::is_whitespace) {
Some((verb, rest)) => format!("{} {}", verb.to_uppercase(), rest),
None => raw.to_uppercase(),
};
// Record in recall list (avoid duplicates at the top).
let raw = self.input.trim().to_string();
if self.cmd_recall.last().map(|s| s.as_str()) != Some(&raw) {
if self.cmd_recall.last().map(|s| s.as_str()) != Some(raw.as_str()) {
self.cmd_recall.push(raw);
if self.cmd_recall.len() > 50 {
self.cmd_recall.remove(0);