AI_Assistant/cad-editor
Watch
1
0
Fork
You've already forked cad-editor
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(trim): preserve source handle in fence pass

Browse source 
Temporary fence pieces used a sentinel handle, so the source spline was included as its own cutting boundary and kernel intersection recursed indefinitely.

Refs #830
This commit is contained in:
Hakan Seven 2026-08-22 01:11:37 +03:00
commit c22f6cde60
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/modules/draw/modify/trim.rs
View file

@ -1777,9 +1777,7 @@ fn fence_pieces(
} }
} }
// Sentinel handle: keeps the self-exclusion in *_seg_ts from matching any let target = e.common().handle;
// real boundary geo while the piece is being re-picked.
const TMP: u64 = u64::MAX - 7;
let mut pieces = vec![e.clone()]; let mut pieces = vec![e.clone()];
let mut changed = false; let mut changed = false;
for _round in 0..8 { for _round in 0..8 {
@ -1787,7 +1785,7 @@ fn fence_pieces(
let mut any = false; let mut any = false;
for piece in &pieces { for piece in &pieces {
let mut tmp = piece.clone(); let mut tmp = piece.clone();
tmp.as_entity_mut().set_handle(Handle::new(TMP)); tmp.as_entity_mut().set_handle(target);
let tmp_all = [tmp]; let tmp_all = [tmp];
let mut consumed = false; let mut consumed = false;
let mut cps = fence_cross_points(&tmp_all[0], fence_geos); let mut cps = fence_cross_points(&tmp_all[0], fence_geos);
@ -1808,10 +1806,10 @@ fn fence_pieces(
} }
for cp in cps { for cp in cps {
let res = if extend { let res = if extend {
pick_extend_at(&tmp_all, geos, Handle::new(TMP), cp[0], cp[1]) pick_extend_at(&tmp_all, geos, target, cp[0], cp[1])
.map(|x| vec![x]) .map(|x| vec![x])
} else { } else {
pick_trim_at(&tmp_all, geos, Handle::new(TMP), cp[0], cp[1]) pick_trim_at(&tmp_all, geos, target, cp[0], cp[1])
}; };
if let Some(mut sub) = res { if let Some(mut sub) = res {
for sp in &mut sub { for sp in &mut sub {