AI_Assistant/cad-editor
Watch
1
0
Fork
You've already forked cad-editor
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

revert: drop wire segment caps that silently truncated geometry

Browse source 
Remove MAX_SEGS_PER_WIRE = 100_000 and MAX_TOTAL_SEGS = 3_000_000.
These were stop-gap GPU-memory guards that mutated visible output:
single complex entities were cut mid-geometry, and entire wires past
the 3M total were dropped by arrival order with no spatial awareness.
Either is worse than honestly drawing whatever the file contains —
truncated arcs and missing road segments look like bugs to the user,
not "we ran out of GPU memory."

The matching "Temporary Workarounds" section in
RENDERING_OPTIMIZATION.md goes with them. Per-entity LOD and
viewport culling (Phase 1 + 3.2 in the same doc) remain the right
long-term answer; until they land, prefer correctness over a soft
crash on pathological files.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Hakan 2026-05-13 10:11:54 +03:00
commit 9b6d5437fa
3 changed files with 3 additions and 94 deletions
Download patch file Download diff file Expand all files Collapse all files

22
src/scene/pipeline/wire_gpu.rs
View file

@ -27,10 +27,6 @@ use crate::scene::wire_model::WireModel;
use iced::wgpu;
use iced::wgpu::util::DeviceExt;
/// Hard cap on segments per wire entity. Entities with more segments are
/// silently truncated to prevent a single complex object from exhausting GPU memory.
pub const MAX_SEGS_PER_WIRE: usize = 100_000;
// ── Vertex layout ─────────────────────────────────────────────────────────
#[repr(C)]
@ -160,14 +156,7 @@ impl WireGpu {
];
let half_width = wire.line_weight_px * 0.5;
let n = wire.points.len();
let raw_segs = n.saturating_sub(1);
let capped_segs = raw_segs.min(MAX_SEGS_PER_WIRE);
if raw_segs > MAX_SEGS_PER_WIRE {
eprintln!(
"[H7CAD] wire '{}': {} segments exceeds limit ({MAX_SEGS_PER_WIRE}), truncating",
wire.name, raw_segs
);
}
let capped_segs = n.saturating_sub(1);
// Cumulative arc-length per point.
let pts_len = capped_segs + 1;
@ -270,14 +259,7 @@ impl WireGpu {
let half_width = wire.line_weight_px * 0.5;
let n = wire.points.len();
let raw_seg_count = if n >= 2 { n - 1 } else { 0 };
let seg_count = raw_seg_count.min(MAX_SEGS_PER_WIRE);
if raw_seg_count > MAX_SEGS_PER_WIRE {
eprintln!(
"[H7CAD] wire '{}': {} segments exceeds limit ({MAX_SEGS_PER_WIRE}), truncating",
wire.name, raw_seg_count
);
}
let seg_count = if n >= 2 { n - 1 } else { 0 };
let mut vertices: Vec<WireVertex> = Vec::with_capacity(seg_count * 6);
// Precompute cumulative arc-length at each point.