AI_Assistant/cad-editor
Watch
1
0
Fork
You've already forked cad-editor
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(render): preserve f64 precision until world_offset subtraction

Browse source 
Entity converters were casting WCS coordinates to f32 before the renderer
subtracted world_offset, which destroyed sub-unit precision on drawings
sitting at large coordinates (typical UTM-style CAD files). The multileader
case made it visible — glyphs warped under rotation — but every entity
that emits TruckObject::Lines/SegmentedLines/key_vertices/fill_tris was
affected.

Type changes (in src/scene/acad_to_truck.rs):
- TruckObject::Lines / SegmentedLines: Vec<[f32; 3]> → Vec<[f64; 3]>
- TruckEntity::key_vertices / fill_tris: f32 → f64

All ~17 producer files updated to keep WCS coordinates in f64 right up to
the TruckEntity boundary. The consumer in scene/tessellate.rs now performs
`(x - ox) as f32` (f64 subtract, then cast) for points, key_vertices, and
fill_tris — preserving precision near the camera origin even when the
drawing sits at million-unit coordinates.

catmull_rom_pts (multileader spline) is now f64; the scene path widens its
offset-relative f32 ctrl points to f64 around the call and narrows back at
the output.

Notes:
- Table layout still uses glam::Vec3 (f32) internally; widened to f64 only
  at the TruckEntity boundary for type compatibility. Separate cleanup to
  switch its internal math to f64 is tracked.
- snap_pts and tangent_geoms remain f32 — they are UI feedback (snap
  candidates, tangent hints) and the precision is sufficient there.
This commit is contained in:
Hakan Seven 2026-05-12 23:47:40 +03:00
commit 288ccff95a
20 changed files with 371 additions and 360 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/entities/ray.rs
View file

@ -23,12 +23,12 @@ impl TruckConvertible for Ray {
return None;
}
let (nx, ny, nz) = (dir.x / len, dir.y / len, dir.z / len);
let far = [
(bp.x + nx * DISPLAY_EXTENT) as f32,
(bp.y + ny * DISPLAY_EXTENT) as f32,
(bp.z + nz * DISPLAY_EXTENT) as f32,
let far: [f64; 3] = [
bp.x + nx * DISPLAY_EXTENT,
bp.y + ny * DISPLAY_EXTENT,
bp.z + nz * DISPLAY_EXTENT,
];
let start = [bp.x as f32, bp.y as f32, bp.z as f32];
let start: [f64; 3] = [bp.x, bp.y, bp.z];
Some(TruckEntity {
object: TruckObject::Lines(vec![start, far]),
snap_pts: vec![],
@ -159,21 +159,21 @@ impl TruckConvertible for XLine {
return None;
}
let (nx, ny, nz) = (dir.x / len, dir.y / len, dir.z / len);
let far_pos = [
(bp.x + nx * DISPLAY_EXTENT) as f32,
(bp.y + ny * DISPLAY_EXTENT) as f32,
(bp.z + nz * DISPLAY_EXTENT) as f32,
let far_pos: [f64; 3] = [
bp.x + nx * DISPLAY_EXTENT,
bp.y + ny * DISPLAY_EXTENT,
bp.z + nz * DISPLAY_EXTENT,
];
let far_neg = [
(bp.x - nx * DISPLAY_EXTENT) as f32,
(bp.y - ny * DISPLAY_EXTENT) as f32,
(bp.z - nz * DISPLAY_EXTENT) as f32,
let far_neg: [f64; 3] = [
bp.x - nx * DISPLAY_EXTENT,
bp.y - ny * DISPLAY_EXTENT,
bp.z - nz * DISPLAY_EXTENT,
];
Some(TruckEntity {
object: TruckObject::Lines(vec![far_neg, far_pos]),
snap_pts: vec![],
tangent_geoms: vec![],
key_vertices: vec![[bp.x as f32, bp.y as f32, bp.z as f32]],
key_vertices: vec![[bp.x, bp.y, bp.z]],
fill_tris: vec![],
})
}