fix(explode): correct arc/ellipse direction in mirrored INSERT blocks

Mirrored INSERTs reverse OCS handedness, but acadrust's explode used to
keep the original normal — making CCW-around-normal arcs and ellipses
sweep the wrong way. The fix lives in acadrust 7c711e9, which flips the
new normal when det < 0 and reprojects center/major_axis/angles into the
new OCS. H7CAD's fix_mirrored_arc workaround is no longer needed.
This commit is contained in:
Hakan Seven 2026-05-12 22:04:12 +03:00
commit 200f10fd25
4 changed files with 7 additions and 28 deletions

2
Cargo.lock generated
View file

@ -41,7 +41,7 @@ checksum = "366ffbaa4442f4684d91e2cd7c5ea7c4ed8add41959a31447066e279e432b618"
[[package]]
name = "acadrust"
version = "0.3.4"
source = "git+https://github.com/hakanaktt/acadrust#4025fd212880dfaa9bcb8b0a52b0bc2b3d2d4415"
source = "git+https://github.com/HakanSeven12/acadrust?rev=7c711e9#7c711e9d4bb8fd7e21ea449e335cee9da24d37de"
dependencies = [
"ahash",
"anyhow",

View file

@ -23,4 +23,4 @@ rayon = "1"
windows-sys = { version = "0.59", features = ["Win32_UI_Shell", "Win32_UI_WindowsAndMessaging"] }
[patch.crates-io]
acadrust = { git = "https://github.com/hakanaktt/acadrust" }
acadrust = { git = "https://github.com/HakanSeven12/acadrust", rev = "7c711e9" }

View file

@ -49,14 +49,11 @@ pub fn explode_entity(entity: &EntityType, document: &CadDocument) -> Vec<Entity
EntityType::Polyline2D(p) => explode_polyline2d(p),
EntityType::Polyline(p) => explode_polyline(p),
EntityType::Polyline3D(p) => explode_polyline3d(p),
EntityType::Insert(ins) => {
let is_mirrored = ins.x_scale() * ins.y_scale() < 0.0;
ins.explode_from_document(document)
.into_iter()
.map(normalize_insert_entity)
.map(|sub| fix_mirrored_arc(sub, is_mirrored))
.collect()
}
EntityType::Insert(ins) => ins
.explode_from_document(document)
.into_iter()
.map(normalize_insert_entity)
.collect(),
EntityType::MLine(ml) => explode_mline(ml),
EntityType::Dimension(dim) => explode_dimension(dim),
_ => vec![],
@ -173,22 +170,6 @@ pub fn normalize_entity_for_block(entity: EntityType) -> EntityType {
entity
}
/// Swap arc start/end angles when the INSERT that produced the entity was
/// mirrored (exactly one of x_scale / y_scale is negative). The acadrust
/// explode recalculates endpoint positions correctly but does not reverse the
/// sweep direction, so the arc would otherwise curve the wrong way.
pub fn fix_mirrored_arc(entity: EntityType, is_mirrored: bool) -> EntityType {
if !is_mirrored {
return entity;
}
if let EntityType::Arc(mut arc) = entity {
std::mem::swap(&mut arc.start_angle, &mut arc.end_angle);
EntityType::Arc(arc)
} else {
entity
}
}
fn explode_lwpolyline(p: &LwPolyline) -> Vec<EntityType> {
let n = p.vertices.len();
if n < 2 {

View file

@ -3788,7 +3788,6 @@ fn tessellate_entity(
}
if let EntityType::Insert(ins) = e {
let is_mirrored = ins.x_scale() * ins.y_scale() < 0.0;
// Resolve the INSERT's own style so ByBlock sub-entities can inherit it.
let (ins_color, ins_pat_len, ins_pat, ins_lw_px, _) = render::render_style_for(document, e);
let ins_color = render::adapt_to_bg(ins_color, bg_color);
@ -3797,7 +3796,6 @@ fn tessellate_entity(
.iter()
.cloned()
.map(crate::modules::home::modify::explode::normalize_insert_entity)
.map(|sub| crate::modules::home::modify::explode::fix_mirrored_arc(sub, is_mirrored))
.flat_map(|sub| {
let (sub_color, sub_pattern_length, sub_pattern, sub_line_weight_px, sub_aci) =
render::render_style_for_block_sub(