2026-03-22 14:56:27 +03:00
|
|
|
use acadrust::entities::{BoundaryEdge, Hatch};
|
2026-04-03 19:16:17 +03:00
|
|
|
use glam::Vec3;
|
2026-03-22 14:56:27 +03:00
|
|
|
|
|
|
|
|
use crate::command::EntityTransform;
|
refactor(grip): square-only marker set + oriented stretch handles
Phase 1 of bringing the grip vocabulary in line with the standard
CAD convention: drop the per-position-type shape encoding (Diamond
for translate, Circle for parameter) and use a plain square for
every endpoint / vertex / centre grip. The behavioural midpoint vs
vertex distinction stays — it lives on `GripDef::is_midpoint` and
drives `Translate` vs `Absolute` in the grip-edit dispatcher — only
the marker shape collapses.
- `GripShape` keeps `Square`, `Rectangle`, `Triangle`. Diamond /
Circle are gone.
- `GripDef` gains `dir: Option<[f32; 2]>` — a world-XY direction
vector consumed by `Rectangle` to orient the box along its
segment.
- `entities::common` exposes `square_grip`, `center_grip` (same
square marker, flagged as translate), `rectangle_grip(id, world,
dir)` for oriented mid-segment handles, and a kept-for-Phase-2
`triangle_grip`.
- `overlay::GripMarker` / `grips_to_screen[_paper]` thread `dir`
through to the canvas painter; the Rectangle path rotates the
box around the grip centre using the world-XY direction (flipping
the sin for screen-Y).
Every existing `diamond_grip(id, w)` call becomes `center_grip(id,
w)` — the visual change is square-replacing-diamond at line
midpoints / arc midpoints / circle centres / ellipse centres /
viewport / hatch loop centroids / dimension grips / image corners /
multileader / ray / underlay / ole2frame / solid3d.
`LwPolyline` grows a stretch handle on every segment (straight or
arc), drawn as the new oriented rectangle. The grip-edit path
translates both segment endpoints for straight segments and
adjusts the arc bulge from the new midpoint for arc segments.
2026-05-29 02:07:34 +03:00
|
|
|
use crate::entities::common::{center_grip, edit_prop as edit, parse_f64, ro_prop as ro};
|
2026-06-11 00:04:37 +03:00
|
|
|
use crate::entities::traits::{FallbackTess, Grippable, PropertyEditable, Transformable};
|
2026-06-16 11:33:46 +03:00
|
|
|
use crate::scene::model::object::{GripApply, GripDef, PropSection, PropValue, Property};
|
|
|
|
|
use crate::scene::convert::tess_util::{arc_segments, arc_signed_span, wire_chord_tol, FallbackGeometry};
|
|
|
|
|
use crate::scene::model::wire_model::SnapHint;
|
2026-03-22 14:56:27 +03:00
|
|
|
|
feat(properties): conform entity property groups to PROPERTIES.md
Rewrite each entity's property builder to the per-entity group/row spec:
the correct sections (Geometry, Misc, Text, Pattern, Lines & Arrows, Leaders,
Block, …) with the spec's rows and real computed values — Diameter,
Circumference, Area, Delta X/Y/Z, Angle, Total angle, Arc length, Radius ratio,
etc. — plus apply routing for the editable rows.
Covers ~26 entities (Line, Circle, Arc, Point, Ellipse, Spline, polylines,
Ray/XLine, Insert, Text, MText, Hatch, Leader, MultiLeader, Tolerance, Solid,
Solid3D/Region/Body, meshes, MLine, Raster/Wipeout, Underlay, Table, Viewport,
Attribute, OLE). The 3D Visualization/Material group and the full Dimension
spec are deferred (they need document access for material/dimstyle name
resolution). Rows whose data is not in the pinned acadrust revision are shown
as empty placeholders, to be filled when the dependency is bumped.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-02 23:03:18 +03:00
|
|
|
/// Signed area of every boundary path, summed via the shoelace formula over
|
|
|
|
|
/// the OCS boundary vertices (bulge/curved edges approximated by their end
|
|
|
|
|
/// points). Returns the absolute total area.
|
|
|
|
|
fn boundary_area(h: &Hatch) -> f64 {
|
|
|
|
|
let mut area = 0.0;
|
|
|
|
|
for path in &h.paths {
|
|
|
|
|
let mut ring: Vec<[f64; 2]> = Vec::new();
|
|
|
|
|
for edge in &path.edges {
|
|
|
|
|
match edge {
|
|
|
|
|
BoundaryEdge::Polyline(poly) => {
|
|
|
|
|
for v in &poly.vertices {
|
|
|
|
|
ring.push([v.x, v.y]);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
BoundaryEdge::Line(l) => {
|
|
|
|
|
ring.push([l.start.x, l.start.y]);
|
|
|
|
|
ring.push([l.end.x, l.end.y]);
|
|
|
|
|
}
|
|
|
|
|
BoundaryEdge::CircularArc(a) => ring.push([a.center.x, a.center.y]),
|
|
|
|
|
BoundaryEdge::EllipticArc(e) => ring.push([e.center.x, e.center.y]),
|
|
|
|
|
BoundaryEdge::Spline(s) => {
|
|
|
|
|
let src = if !s.fit_points.is_empty() {
|
|
|
|
|
s.fit_points.iter().map(|p| [p.x, p.y]).collect::<Vec<_>>()
|
|
|
|
|
} else {
|
|
|
|
|
s.control_points
|
|
|
|
|
.iter()
|
|
|
|
|
.map(|p| [p.x, p.y])
|
|
|
|
|
.collect::<Vec<_>>()
|
|
|
|
|
};
|
|
|
|
|
ring.extend(src);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
let n = ring.len();
|
|
|
|
|
if n < 3 {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
let mut acc = 0.0;
|
|
|
|
|
for i in 0..n {
|
|
|
|
|
let a = ring[i];
|
|
|
|
|
let b = ring[(i + 1) % n];
|
|
|
|
|
acc += a[0] * b[1] - b[0] * a[1];
|
|
|
|
|
}
|
|
|
|
|
area += acc.abs() * 0.5;
|
|
|
|
|
}
|
|
|
|
|
area
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Format a color for a read-only row (`ByLayer` / `ByBlock` / index / RGB).
|
|
|
|
|
fn color_str(c: acadrust::types::Color) -> String {
|
|
|
|
|
c.to_string()
|
|
|
|
|
}
|
|
|
|
|
|
2026-07-02 22:46:19 +03:00
|
|
|
fn properties(h: &Hatch) -> Vec<PropSection> {
|
2026-03-22 14:56:27 +03:00
|
|
|
let pattern_type = match h.pattern_type {
|
|
|
|
|
acadrust::entities::HatchPatternType::Predefined => "Predefined",
|
|
|
|
|
acadrust::entities::HatchPatternType::UserDefined => "User Defined",
|
|
|
|
|
acadrust::entities::HatchPatternType::Custom => "Custom",
|
|
|
|
|
};
|
|
|
|
|
let style = match h.style {
|
|
|
|
|
acadrust::entities::HatchStyleType::Normal => "Normal",
|
|
|
|
|
acadrust::entities::HatchStyleType::Outer => "Outer",
|
|
|
|
|
acadrust::entities::HatchStyleType::Ignore => "Ignore",
|
|
|
|
|
};
|
feat(properties): conform entity property groups to PROPERTIES.md
Rewrite each entity's property builder to the per-entity group/row spec:
the correct sections (Geometry, Misc, Text, Pattern, Lines & Arrows, Leaders,
Block, …) with the spec's rows and real computed values — Diameter,
Circumference, Area, Delta X/Y/Z, Angle, Total angle, Arc length, Radius ratio,
etc. — plus apply routing for the editable rows.
Covers ~26 entities (Line, Circle, Arc, Point, Ellipse, Spline, polylines,
Ray/XLine, Insert, Text, MText, Hatch, Leader, MultiLeader, Tolerance, Solid,
Solid3D/Region/Body, meshes, MLine, Raster/Wipeout, Underlay, Table, Viewport,
Attribute, OLE). The 3D Visualization/Material group and the full Dimension
spec are deferred (they need document access for material/dimstyle name
resolution). Rows whose data is not in the pinned acadrust revision are shown
as empty placeholders, to be filled when the dependency is bumped.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-02 23:03:18 +03:00
|
|
|
let area = boundary_area(h);
|
|
|
|
|
let g = &h.gradient_color;
|
|
|
|
|
let grad_c1 = g.colors.first().map(|e| color_str(e.color)).unwrap_or_default();
|
|
|
|
|
let grad_c2 = g.colors.get(1).map(|e| color_str(e.color)).unwrap_or_default();
|
|
|
|
|
|
|
|
|
|
if g.enabled {
|
|
|
|
|
// ── Gradient fill ──────────────────────────────────────────────────
|
|
|
|
|
let grad_type = if g.is_single_color { "One color" } else { "Two color" };
|
|
|
|
|
let centered = if g.shift.abs() < 1e-9 { "Yes" } else { "No" };
|
|
|
|
|
return vec![
|
|
|
|
|
PropSection {
|
|
|
|
|
title: "Pattern".into(),
|
|
|
|
|
props: vec![
|
|
|
|
|
ro("Type", "fill_type", grad_type),
|
|
|
|
|
ro("Gradient name", "gradient_name", g.name.clone()),
|
|
|
|
|
ro("Color 1", "gradient_color_1", grad_c1),
|
|
|
|
|
ro("Color 2", "gradient_color_2", grad_c2),
|
|
|
|
|
edit("Angle", "pattern_angle", g.angle.to_degrees()),
|
|
|
|
|
ro("Centered", "gradient_centered", centered),
|
|
|
|
|
],
|
|
|
|
|
},
|
|
|
|
|
PropSection {
|
|
|
|
|
title: "Geometry".into(),
|
|
|
|
|
props: vec![
|
|
|
|
|
edit("Elevation", "elevation", h.elevation),
|
|
|
|
|
ro("Origin X", "origin_x", String::new()),
|
|
|
|
|
ro("Origin Y", "origin_y", String::new()),
|
|
|
|
|
ro("Area", "area", format!("{:.4}", area)),
|
|
|
|
|
ro("Cumulative area", "cumulative_area", format!("{:.4}", area)),
|
|
|
|
|
],
|
|
|
|
|
},
|
|
|
|
|
PropSection {
|
|
|
|
|
title: "Misc".into(),
|
|
|
|
|
props: vec![
|
|
|
|
|
ro(
|
|
|
|
|
"Associative",
|
|
|
|
|
"associative",
|
|
|
|
|
if h.is_associative { "Yes" } else { "No" },
|
|
|
|
|
),
|
|
|
|
|
ro("Annotative", "annotative", String::new()),
|
|
|
|
|
ro("Island detection style", "style", style),
|
|
|
|
|
ro("Background color", "background_color", String::new()),
|
|
|
|
|
],
|
2026-03-22 14:56:27 +03:00
|
|
|
},
|
feat(properties): conform entity property groups to PROPERTIES.md
Rewrite each entity's property builder to the per-entity group/row spec:
the correct sections (Geometry, Misc, Text, Pattern, Lines & Arrows, Leaders,
Block, …) with the spec's rows and real computed values — Diameter,
Circumference, Area, Delta X/Y/Z, Angle, Total angle, Arc length, Radius ratio,
etc. — plus apply routing for the editable rows.
Covers ~26 entities (Line, Circle, Arc, Point, Ellipse, Spline, polylines,
Ray/XLine, Insert, Text, MText, Hatch, Leader, MultiLeader, Tolerance, Solid,
Solid3D/Region/Body, meshes, MLine, Raster/Wipeout, Underlay, Table, Viewport,
Attribute, OLE). The 3D Visualization/Material group and the full Dimension
spec are deferred (they need document access for material/dimstyle name
resolution). Rows whose data is not in the pinned acadrust revision are shown
as empty placeholders, to be filled when the dependency is bumped.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-02 23:03:18 +03:00
|
|
|
];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// ── Hatch (pattern / solid) ────────────────────────────────────────────
|
|
|
|
|
let hatch_type = if h.is_solid { "Solid" } else { "Pattern" };
|
|
|
|
|
vec![
|
|
|
|
|
PropSection {
|
|
|
|
|
title: "Pattern".into(),
|
|
|
|
|
props: vec![
|
|
|
|
|
ro("Type", "pattern_type_label", hatch_type),
|
|
|
|
|
Property {
|
|
|
|
|
label: "Pattern name".into(),
|
|
|
|
|
field: "pattern_name",
|
|
|
|
|
value: PropValue::HatchPatternChoice(h.pattern.name.clone()),
|
|
|
|
|
},
|
|
|
|
|
ro("Color", "color", color_str(h.common.color)),
|
|
|
|
|
ro("Background color", "background_color", String::new()),
|
|
|
|
|
ro(
|
|
|
|
|
"Transparency",
|
|
|
|
|
"transparency",
|
|
|
|
|
format!("{}%", (h.common.transparency.as_percent() * 100.0).round() as i32),
|
|
|
|
|
),
|
|
|
|
|
edit("Angle", "pattern_angle", h.pattern_angle.to_degrees()),
|
|
|
|
|
edit("Scale", "pattern_scale", h.pattern_scale),
|
|
|
|
|
ro("Origin X", "origin_x", String::new()),
|
|
|
|
|
ro("Origin Y", "origin_y", String::new()),
|
|
|
|
|
ro("Annotative", "annotative", String::new()),
|
|
|
|
|
ro(
|
|
|
|
|
"Associative",
|
|
|
|
|
"associative",
|
|
|
|
|
if h.is_associative { "Yes" } else { "No" },
|
|
|
|
|
),
|
|
|
|
|
ro("Layer override", "layer_override", String::new()),
|
2026-07-03 08:06:00 +03:00
|
|
|
Property {
|
|
|
|
|
label: "Double".into(),
|
|
|
|
|
field: "double",
|
|
|
|
|
value: PropValue::BoolToggle {
|
|
|
|
|
field: "double",
|
|
|
|
|
value: h.is_double,
|
|
|
|
|
},
|
|
|
|
|
},
|
2026-07-03 00:05:58 +03:00
|
|
|
ro(
|
|
|
|
|
"Spacing",
|
|
|
|
|
"spacing",
|
|
|
|
|
h.pattern
|
|
|
|
|
.lines
|
|
|
|
|
.first()
|
|
|
|
|
.map(|l| format!("{:.4}", l.offset.length()))
|
|
|
|
|
.unwrap_or_default(),
|
|
|
|
|
),
|
feat(properties): conform entity property groups to PROPERTIES.md
Rewrite each entity's property builder to the per-entity group/row spec:
the correct sections (Geometry, Misc, Text, Pattern, Lines & Arrows, Leaders,
Block, …) with the spec's rows and real computed values — Diameter,
Circumference, Area, Delta X/Y/Z, Angle, Total angle, Arc length, Radius ratio,
etc. — plus apply routing for the editable rows.
Covers ~26 entities (Line, Circle, Arc, Point, Ellipse, Spline, polylines,
Ray/XLine, Insert, Text, MText, Hatch, Leader, MultiLeader, Tolerance, Solid,
Solid3D/Region/Body, meshes, MLine, Raster/Wipeout, Underlay, Table, Viewport,
Attribute, OLE). The 3D Visualization/Material group and the full Dimension
spec are deferred (they need document access for material/dimstyle name
resolution). Rows whose data is not in the pinned acadrust revision are shown
as empty placeholders, to be filled when the dependency is bumped.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-02 23:03:18 +03:00
|
|
|
ro("ISO pen width", "iso_pen_width", String::new()),
|
|
|
|
|
ro("Gradient colors", "gradient_colors", g.colors.len().to_string()),
|
|
|
|
|
ro("Gradient tint", "gradient_tint", format!("{:.4}", g.color_tint)),
|
|
|
|
|
ro("Gradient color 1", "gradient_color_1", grad_c1),
|
|
|
|
|
ro("Gradient color 2", "gradient_color_2", grad_c2),
|
|
|
|
|
ro("Pattern type", "pattern_type", pattern_type),
|
|
|
|
|
],
|
|
|
|
|
},
|
|
|
|
|
PropSection {
|
|
|
|
|
title: "Geometry".into(),
|
|
|
|
|
props: vec![
|
|
|
|
|
edit("Elevation", "elevation", h.elevation),
|
|
|
|
|
ro("Area", "area", format!("{:.4}", area)),
|
|
|
|
|
ro("Cumulative area", "cumulative_area", format!("{:.4}", area)),
|
|
|
|
|
],
|
|
|
|
|
},
|
|
|
|
|
PropSection {
|
|
|
|
|
title: "Misc".into(),
|
|
|
|
|
props: vec![
|
|
|
|
|
ro("Boundary retention", "boundary_retention", String::new()),
|
|
|
|
|
ro("Island detection style", "style", style),
|
|
|
|
|
],
|
|
|
|
|
},
|
|
|
|
|
]
|
2026-03-22 14:56:27 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn apply_geom_prop(h: &mut Hatch, field: &str, value: &str) {
|
2026-07-03 08:06:00 +03:00
|
|
|
if field == "double" {
|
|
|
|
|
h.is_double = if value == "toggle" {
|
|
|
|
|
!h.is_double
|
|
|
|
|
} else {
|
|
|
|
|
value == "true"
|
|
|
|
|
};
|
|
|
|
|
return;
|
|
|
|
|
}
|
2026-03-22 14:56:27 +03:00
|
|
|
let Some(v) = parse_f64(value) else {
|
|
|
|
|
return;
|
|
|
|
|
};
|
|
|
|
|
match field {
|
feat(properties): conform entity property groups to PROPERTIES.md
Rewrite each entity's property builder to the per-entity group/row spec:
the correct sections (Geometry, Misc, Text, Pattern, Lines & Arrows, Leaders,
Block, …) with the spec's rows and real computed values — Diameter,
Circumference, Area, Delta X/Y/Z, Angle, Total angle, Arc length, Radius ratio,
etc. — plus apply routing for the editable rows.
Covers ~26 entities (Line, Circle, Arc, Point, Ellipse, Spline, polylines,
Ray/XLine, Insert, Text, MText, Hatch, Leader, MultiLeader, Tolerance, Solid,
Solid3D/Region/Body, meshes, MLine, Raster/Wipeout, Underlay, Table, Viewport,
Attribute, OLE). The 3D Visualization/Material group and the full Dimension
spec are deferred (they need document access for material/dimstyle name
resolution). Rows whose data is not in the pinned acadrust revision are shown
as empty placeholders, to be filled when the dependency is bumped.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-02 23:03:18 +03:00
|
|
|
"pattern_angle" if h.gradient_color.enabled => h.gradient_color.angle = v.to_radians(),
|
2026-03-22 14:56:27 +03:00
|
|
|
"pattern_angle" => h.pattern_angle = v.to_radians(),
|
|
|
|
|
"pattern_scale" if v > 0.0 => h.pattern_scale = v,
|
|
|
|
|
"elevation" => h.elevation = v,
|
|
|
|
|
_ => {}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn apply_transform(h: &mut Hatch, t: &EntityTransform) {
|
2026-06-16 11:33:46 +03:00
|
|
|
crate::scene::view::transform::apply_standard_entity_transform(h, t, |entity, p1, p2| {
|
2026-06-11 09:03:18 +03:00
|
|
|
// Delegate the mirror to acadrust's transform_hatch (via the Entity
|
|
|
|
|
// trait): it flips the boundary-arc direction flags, re-mirrors the
|
|
|
|
|
// stored angles and preserves the stored sweep — including the
|
|
|
|
|
// wrap-encoded end angles above 2π that AutoCAD writes. The old
|
|
|
|
|
// hand-rolled angle-swap here was only valid for ccw boundary arcs on
|
|
|
|
|
// an axis-aligned mirror line and went stale the moment those
|
|
|
|
|
// conventions were fixed upstream.
|
2026-06-16 11:33:46 +03:00
|
|
|
let t = crate::scene::view::transform::reflection_about_xy_line(p1, p2);
|
2026-06-11 09:03:18 +03:00
|
|
|
acadrust::entities::Entity::apply_transform(entity, &t);
|
2026-03-22 14:56:27 +03:00
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl PropertyEditable for Hatch {
|
2026-07-02 22:46:19 +03:00
|
|
|
fn geometry_properties(&self, _text_style_names: &[String]) -> Vec<PropSection> {
|
2026-03-22 14:56:27 +03:00
|
|
|
properties(self)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn apply_geom_prop(&mut self, field: &str, value: &str) {
|
|
|
|
|
apply_geom_prop(self, field, value);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl Transformable for Hatch {
|
|
|
|
|
fn apply_transform(&mut self, t: &EntityTransform) {
|
|
|
|
|
apply_transform(self, t);
|
|
|
|
|
}
|
|
|
|
|
}
|
2026-04-03 19:16:17 +03:00
|
|
|
|
|
|
|
|
// ── Grip editing ───────────────────────────────────────────────────────────
|
|
|
|
|
|
|
|
|
|
/// Assign sequential grip IDs across all boundary paths and edges.
|
|
|
|
|
/// Exposed control points per edge type:
|
|
|
|
|
/// Polyline → each vertex (x, y)
|
|
|
|
|
/// Line → start, end
|
|
|
|
|
/// CircularArc → center
|
|
|
|
|
/// EllipticArc → center
|
|
|
|
|
/// Spline → fit points if present, else control points (x, y)
|
|
|
|
|
impl Grippable for Hatch {
|
|
|
|
|
fn grips(&self) -> Vec<GripDef> {
|
2026-06-11 00:04:37 +03:00
|
|
|
let elev = self.elevation;
|
2026-04-03 19:16:17 +03:00
|
|
|
let mut out = Vec::new();
|
|
|
|
|
let mut id = 0usize;
|
|
|
|
|
for path in &self.paths {
|
|
|
|
|
for edge in &path.edges {
|
|
|
|
|
match edge {
|
|
|
|
|
BoundaryEdge::Polyline(p) => {
|
|
|
|
|
for v in &p.vertices {
|
2026-06-11 00:04:37 +03:00
|
|
|
out.push(center_grip(id, glam::DVec3::new(v.x, v.y, elev)));
|
2026-04-03 19:16:17 +03:00
|
|
|
id += 1;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
BoundaryEdge::Line(l) => {
|
refactor(grip): square-only marker set + oriented stretch handles
Phase 1 of bringing the grip vocabulary in line with the standard
CAD convention: drop the per-position-type shape encoding (Diamond
for translate, Circle for parameter) and use a plain square for
every endpoint / vertex / centre grip. The behavioural midpoint vs
vertex distinction stays — it lives on `GripDef::is_midpoint` and
drives `Translate` vs `Absolute` in the grip-edit dispatcher — only
the marker shape collapses.
- `GripShape` keeps `Square`, `Rectangle`, `Triangle`. Diamond /
Circle are gone.
- `GripDef` gains `dir: Option<[f32; 2]>` — a world-XY direction
vector consumed by `Rectangle` to orient the box along its
segment.
- `entities::common` exposes `square_grip`, `center_grip` (same
square marker, flagged as translate), `rectangle_grip(id, world,
dir)` for oriented mid-segment handles, and a kept-for-Phase-2
`triangle_grip`.
- `overlay::GripMarker` / `grips_to_screen[_paper]` thread `dir`
through to the canvas painter; the Rectangle path rotates the
box around the grip centre using the world-XY direction (flipping
the sin for screen-Y).
Every existing `diamond_grip(id, w)` call becomes `center_grip(id,
w)` — the visual change is square-replacing-diamond at line
midpoints / arc midpoints / circle centres / ellipse centres /
viewport / hatch loop centroids / dimension grips / image corners /
multileader / ray / underlay / ole2frame / solid3d.
`LwPolyline` grows a stretch handle on every segment (straight or
arc), drawn as the new oriented rectangle. The grip-edit path
translates both segment endpoints for straight segments and
adjusts the arc bulge from the new midpoint for arc segments.
2026-05-29 02:07:34 +03:00
|
|
|
out.push(center_grip(
|
2026-05-12 10:36:15 +03:00
|
|
|
id,
|
2026-06-11 00:04:37 +03:00
|
|
|
glam::DVec3::new(l.start.x, l.start.y, elev),
|
2026-05-12 10:36:15 +03:00
|
|
|
));
|
2026-04-03 19:16:17 +03:00
|
|
|
id += 1;
|
2026-06-11 00:04:37 +03:00
|
|
|
out.push(center_grip(id, glam::DVec3::new(l.end.x, l.end.y, elev)));
|
2026-04-03 19:16:17 +03:00
|
|
|
id += 1;
|
|
|
|
|
}
|
|
|
|
|
BoundaryEdge::CircularArc(a) => {
|
refactor(grip): square-only marker set + oriented stretch handles
Phase 1 of bringing the grip vocabulary in line with the standard
CAD convention: drop the per-position-type shape encoding (Diamond
for translate, Circle for parameter) and use a plain square for
every endpoint / vertex / centre grip. The behavioural midpoint vs
vertex distinction stays — it lives on `GripDef::is_midpoint` and
drives `Translate` vs `Absolute` in the grip-edit dispatcher — only
the marker shape collapses.
- `GripShape` keeps `Square`, `Rectangle`, `Triangle`. Diamond /
Circle are gone.
- `GripDef` gains `dir: Option<[f32; 2]>` — a world-XY direction
vector consumed by `Rectangle` to orient the box along its
segment.
- `entities::common` exposes `square_grip`, `center_grip` (same
square marker, flagged as translate), `rectangle_grip(id, world,
dir)` for oriented mid-segment handles, and a kept-for-Phase-2
`triangle_grip`.
- `overlay::GripMarker` / `grips_to_screen[_paper]` thread `dir`
through to the canvas painter; the Rectangle path rotates the
box around the grip centre using the world-XY direction (flipping
the sin for screen-Y).
Every existing `diamond_grip(id, w)` call becomes `center_grip(id,
w)` — the visual change is square-replacing-diamond at line
midpoints / arc midpoints / circle centres / ellipse centres /
viewport / hatch loop centroids / dimension grips / image corners /
multileader / ray / underlay / ole2frame / solid3d.
`LwPolyline` grows a stretch handle on every segment (straight or
arc), drawn as the new oriented rectangle. The grip-edit path
translates both segment endpoints for straight segments and
adjusts the arc bulge from the new midpoint for arc segments.
2026-05-29 02:07:34 +03:00
|
|
|
out.push(center_grip(
|
2026-05-12 10:36:15 +03:00
|
|
|
id,
|
2026-06-11 00:04:37 +03:00
|
|
|
glam::DVec3::new(a.center.x, a.center.y, elev),
|
2026-05-12 10:36:15 +03:00
|
|
|
));
|
2026-04-03 19:16:17 +03:00
|
|
|
id += 1;
|
|
|
|
|
}
|
|
|
|
|
BoundaryEdge::EllipticArc(e) => {
|
refactor(grip): square-only marker set + oriented stretch handles
Phase 1 of bringing the grip vocabulary in line with the standard
CAD convention: drop the per-position-type shape encoding (Diamond
for translate, Circle for parameter) and use a plain square for
every endpoint / vertex / centre grip. The behavioural midpoint vs
vertex distinction stays — it lives on `GripDef::is_midpoint` and
drives `Translate` vs `Absolute` in the grip-edit dispatcher — only
the marker shape collapses.
- `GripShape` keeps `Square`, `Rectangle`, `Triangle`. Diamond /
Circle are gone.
- `GripDef` gains `dir: Option<[f32; 2]>` — a world-XY direction
vector consumed by `Rectangle` to orient the box along its
segment.
- `entities::common` exposes `square_grip`, `center_grip` (same
square marker, flagged as translate), `rectangle_grip(id, world,
dir)` for oriented mid-segment handles, and a kept-for-Phase-2
`triangle_grip`.
- `overlay::GripMarker` / `grips_to_screen[_paper]` thread `dir`
through to the canvas painter; the Rectangle path rotates the
box around the grip centre using the world-XY direction (flipping
the sin for screen-Y).
Every existing `diamond_grip(id, w)` call becomes `center_grip(id,
w)` — the visual change is square-replacing-diamond at line
midpoints / arc midpoints / circle centres / ellipse centres /
viewport / hatch loop centroids / dimension grips / image corners /
multileader / ray / underlay / ole2frame / solid3d.
`LwPolyline` grows a stretch handle on every segment (straight or
arc), drawn as the new oriented rectangle. The grip-edit path
translates both segment endpoints for straight segments and
adjusts the arc bulge from the new midpoint for arc segments.
2026-05-29 02:07:34 +03:00
|
|
|
out.push(center_grip(
|
2026-05-12 10:36:15 +03:00
|
|
|
id,
|
2026-06-11 00:04:37 +03:00
|
|
|
glam::DVec3::new(e.center.x, e.center.y, elev),
|
2026-05-12 10:36:15 +03:00
|
|
|
));
|
2026-04-03 19:16:17 +03:00
|
|
|
id += 1;
|
|
|
|
|
}
|
|
|
|
|
BoundaryEdge::Spline(s) => {
|
|
|
|
|
let pts: Vec<[f64; 2]> = if !s.fit_points.is_empty() {
|
|
|
|
|
s.fit_points.iter().map(|p| [p.x, p.y]).collect()
|
|
|
|
|
} else {
|
|
|
|
|
s.control_points.iter().map(|p| [p.x, p.y]).collect()
|
|
|
|
|
};
|
|
|
|
|
for [x, y] in pts {
|
2026-06-11 00:04:37 +03:00
|
|
|
out.push(center_grip(id, glam::DVec3::new(x, y, elev)));
|
2026-04-03 19:16:17 +03:00
|
|
|
id += 1;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
out
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn apply_grip(&mut self, grip_id: usize, apply: GripApply) {
|
|
|
|
|
let elev = self.elevation as f32;
|
|
|
|
|
let mut id = 0usize;
|
|
|
|
|
|
|
|
|
|
fn resolve(apply: &GripApply, cur: Vec3) -> (f64, f64) {
|
|
|
|
|
let p = match apply {
|
|
|
|
|
GripApply::Absolute(p) => *p,
|
feat(f64): command layer compiles on DVec3
Whole command/snap/grip/cursor chain now builds on f64 DVec3 end to end,
so picked points, snaps and grip drags stay precise at UTM-scale
coordinates instead of quantizing to ~0.5 m through f32.
- All ~80 command files migrated: draw (line/circle/arc/ellipse/shapes
in full f64; others via point methods), modify, annotate, insert, view,
inquiry, layers, groups, clipboard, layout.
- Entity apply_grip impls updated for GripApply::{Absolute,Translate}(DVec3).
- Construction sites (EntityTransform/CmdResult/DynAnchor) emit DVec3;
wire-preview boundaries cast to f32 only at the GPU edge.
- Modify/annotate commands keep internal Vec3 geometry where precision is
non-critical, casting at the DVec3 boundary; key draw commands store f64.
Builds clean (no warnings). Visual verification of crosshair/snap/grip at
extreme UTM zoom pending.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 03:51:50 +03:00
|
|
|
GripApply::Translate(d) => cur.as_dvec3() + *d,
|
2026-04-03 19:16:17 +03:00
|
|
|
};
|
feat(f64): command layer compiles on DVec3
Whole command/snap/grip/cursor chain now builds on f64 DVec3 end to end,
so picked points, snaps and grip drags stay precise at UTM-scale
coordinates instead of quantizing to ~0.5 m through f32.
- All ~80 command files migrated: draw (line/circle/arc/ellipse/shapes
in full f64; others via point methods), modify, annotate, insert, view,
inquiry, layers, groups, clipboard, layout.
- Entity apply_grip impls updated for GripApply::{Absolute,Translate}(DVec3).
- Construction sites (EntityTransform/CmdResult/DynAnchor) emit DVec3;
wire-preview boundaries cast to f32 only at the GPU edge.
- Modify/annotate commands keep internal Vec3 geometry where precision is
non-critical, casting at the DVec3 boundary; key draw commands store f64.
Builds clean (no warnings). Visual verification of crosshair/snap/grip at
extreme UTM zoom pending.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 03:51:50 +03:00
|
|
|
(p.x, p.y)
|
2026-04-03 19:16:17 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
'outer: for path in &mut self.paths {
|
|
|
|
|
for edge in &mut path.edges {
|
|
|
|
|
match edge {
|
|
|
|
|
BoundaryEdge::Polyline(p) => {
|
|
|
|
|
for v in &mut p.vertices {
|
|
|
|
|
if id == grip_id {
|
2026-05-12 10:36:15 +03:00
|
|
|
let (nx, ny) =
|
|
|
|
|
resolve(&apply, Vec3::new(v.x as f32, v.y as f32, elev));
|
2026-04-03 19:16:17 +03:00
|
|
|
v.x = nx;
|
|
|
|
|
v.y = ny;
|
|
|
|
|
break 'outer;
|
|
|
|
|
}
|
|
|
|
|
id += 1;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
BoundaryEdge::Line(l) => {
|
|
|
|
|
if id == grip_id {
|
2026-05-12 10:36:15 +03:00
|
|
|
let (nx, ny) = resolve(
|
|
|
|
|
&apply,
|
|
|
|
|
Vec3::new(l.start.x as f32, l.start.y as f32, elev),
|
|
|
|
|
);
|
2026-04-03 19:16:17 +03:00
|
|
|
l.start.x = nx;
|
|
|
|
|
l.start.y = ny;
|
|
|
|
|
break 'outer;
|
|
|
|
|
}
|
|
|
|
|
id += 1;
|
|
|
|
|
if id == grip_id {
|
2026-05-12 10:36:15 +03:00
|
|
|
let (nx, ny) =
|
|
|
|
|
resolve(&apply, Vec3::new(l.end.x as f32, l.end.y as f32, elev));
|
2026-04-03 19:16:17 +03:00
|
|
|
l.end.x = nx;
|
|
|
|
|
l.end.y = ny;
|
|
|
|
|
break 'outer;
|
|
|
|
|
}
|
|
|
|
|
id += 1;
|
|
|
|
|
}
|
|
|
|
|
BoundaryEdge::CircularArc(a) => {
|
|
|
|
|
if id == grip_id {
|
2026-05-12 10:36:15 +03:00
|
|
|
let (nx, ny) = resolve(
|
|
|
|
|
&apply,
|
|
|
|
|
Vec3::new(a.center.x as f32, a.center.y as f32, elev),
|
|
|
|
|
);
|
2026-04-03 19:16:17 +03:00
|
|
|
a.center.x = nx;
|
|
|
|
|
a.center.y = ny;
|
|
|
|
|
break 'outer;
|
|
|
|
|
}
|
|
|
|
|
id += 1;
|
|
|
|
|
}
|
|
|
|
|
BoundaryEdge::EllipticArc(e) => {
|
|
|
|
|
if id == grip_id {
|
2026-05-12 10:36:15 +03:00
|
|
|
let (nx, ny) = resolve(
|
|
|
|
|
&apply,
|
|
|
|
|
Vec3::new(e.center.x as f32, e.center.y as f32, elev),
|
|
|
|
|
);
|
2026-04-03 19:16:17 +03:00
|
|
|
e.center.x = nx;
|
|
|
|
|
e.center.y = ny;
|
|
|
|
|
break 'outer;
|
|
|
|
|
}
|
|
|
|
|
id += 1;
|
|
|
|
|
}
|
|
|
|
|
BoundaryEdge::Spline(s) => {
|
|
|
|
|
if !s.fit_points.is_empty() {
|
|
|
|
|
for fp in &mut s.fit_points {
|
|
|
|
|
if id == grip_id {
|
2026-05-12 10:36:15 +03:00
|
|
|
let (nx, ny) =
|
|
|
|
|
resolve(&apply, Vec3::new(fp.x as f32, fp.y as f32, elev));
|
2026-04-03 19:16:17 +03:00
|
|
|
fp.x = nx;
|
|
|
|
|
fp.y = ny;
|
|
|
|
|
break 'outer;
|
|
|
|
|
}
|
|
|
|
|
id += 1;
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
for cp in &mut s.control_points {
|
|
|
|
|
if id == grip_id {
|
2026-05-12 10:36:15 +03:00
|
|
|
let (nx, ny) =
|
|
|
|
|
resolve(&apply, Vec3::new(cp.x as f32, cp.y as f32, elev));
|
2026-04-03 19:16:17 +03:00
|
|
|
cp.x = nx;
|
|
|
|
|
cp.y = ny;
|
|
|
|
|
break 'outer;
|
|
|
|
|
}
|
|
|
|
|
id += 1;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
feat(grip): popup menus for polylines, spline, mline, hatch, leaders, text
Vocabulary added: AddFitPoint, RemoveFitPoint, Refit, RefineVertices,
TangentDirection, MoveWithText, StackText, UnstackText.
Polyline/Polyline2D/Polyline3D: vertex Add/Remove. MLine: same.
Spline: CV Add/Remove plus Refine Vertices (chord-midpoint insertion,
weights kept in sync, knots cleared so to_truck rebuilds uniform vec).
Hatch: centroid Origin/Angle/Scale (Angle and Scale prompt for value).
Leader: vertex Add/Remove (arrow + centroid stay Stretch-only).
MultiLeader: vertex Add/Remove Leader; MText location Move-with-Leader /
Move-Independent (menu live, structural edits stubbed). Text/MText:
Rotate prompts for degrees and sets rotation.
Spline, Leader, MultiLeader switched from impl_entity_basics! to manual
trait impls so grip_menu can be overridden.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-29 15:14:43 +03:00
|
|
|
|
2026-06-16 11:33:46 +03:00
|
|
|
fn grip_menu(&self, _grip_id: usize) -> Vec<crate::scene::model::object::GripMenuItem> {
|
|
|
|
|
use crate::scene::model::object::{GripMenuAction, GripMenuItem};
|
feat(grip): popup menus for polylines, spline, mline, hatch, leaders, text
Vocabulary added: AddFitPoint, RemoveFitPoint, Refit, RefineVertices,
TangentDirection, MoveWithText, StackText, UnstackText.
Polyline/Polyline2D/Polyline3D: vertex Add/Remove. MLine: same.
Spline: CV Add/Remove plus Refine Vertices (chord-midpoint insertion,
weights kept in sync, knots cleared so to_truck rebuilds uniform vec).
Hatch: centroid Origin/Angle/Scale (Angle and Scale prompt for value).
Leader: vertex Add/Remove (arrow + centroid stay Stretch-only).
MultiLeader: vertex Add/Remove Leader; MText location Move-with-Leader /
Move-Independent (menu live, structural edits stubbed). Text/MText:
Rotate prompts for degrees and sets rotation.
Spline, Leader, MultiLeader switched from impl_entity_basics! to manual
trait impls so grip_menu can be overridden.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-29 15:14:43 +03:00
|
|
|
vec![
|
2026-06-11 00:04:37 +03:00
|
|
|
GripMenuItem {
|
|
|
|
|
label: "Stretch",
|
|
|
|
|
action: GripMenuAction::Stretch,
|
|
|
|
|
},
|
|
|
|
|
GripMenuItem {
|
|
|
|
|
label: "Origin Point",
|
|
|
|
|
action: GripMenuAction::OriginPoint,
|
|
|
|
|
},
|
|
|
|
|
GripMenuItem {
|
|
|
|
|
label: "Hatch Angle",
|
|
|
|
|
action: GripMenuAction::HatchAngle,
|
|
|
|
|
},
|
|
|
|
|
GripMenuItem {
|
|
|
|
|
label: "Hatch Scale",
|
|
|
|
|
action: GripMenuAction::HatchScale,
|
|
|
|
|
},
|
feat(grip): popup menus for polylines, spline, mline, hatch, leaders, text
Vocabulary added: AddFitPoint, RemoveFitPoint, Refit, RefineVertices,
TangentDirection, MoveWithText, StackText, UnstackText.
Polyline/Polyline2D/Polyline3D: vertex Add/Remove. MLine: same.
Spline: CV Add/Remove plus Refine Vertices (chord-midpoint insertion,
weights kept in sync, knots cleared so to_truck rebuilds uniform vec).
Hatch: centroid Origin/Angle/Scale (Angle and Scale prompt for value).
Leader: vertex Add/Remove (arrow + centroid stay Stretch-only).
MultiLeader: vertex Add/Remove Leader; MText location Move-with-Leader /
Move-Independent (menu live, structural edits stubbed). Text/MText:
Rotate prompts for degrees and sets rotation.
Spline, Leader, MultiLeader switched from impl_entity_basics! to manual
trait impls so grip_menu can be overridden.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-29 15:14:43 +03:00
|
|
|
]
|
|
|
|
|
}
|
|
|
|
|
|
2026-06-16 11:33:46 +03:00
|
|
|
fn apply_grip_menu(&mut self, _grip_id: usize, _action: crate::scene::model::object::GripMenuAction) {
|
feat(grip): popup menus for polylines, spline, mline, hatch, leaders, text
Vocabulary added: AddFitPoint, RemoveFitPoint, Refit, RefineVertices,
TangentDirection, MoveWithText, StackText, UnstackText.
Polyline/Polyline2D/Polyline3D: vertex Add/Remove. MLine: same.
Spline: CV Add/Remove plus Refine Vertices (chord-midpoint insertion,
weights kept in sync, knots cleared so to_truck rebuilds uniform vec).
Hatch: centroid Origin/Angle/Scale (Angle and Scale prompt for value).
Leader: vertex Add/Remove (arrow + centroid stay Stretch-only).
MultiLeader: vertex Add/Remove Leader; MText location Move-with-Leader /
Move-Independent (menu live, structural edits stubbed). Text/MText:
Rotate prompts for degrees and sets rotation.
Spline, Leader, MultiLeader switched from impl_entity_basics! to manual
trait impls so grip_menu can be overridden.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-29 15:14:43 +03:00
|
|
|
// Origin / Angle / Scale need a follow-up value — handled by
|
|
|
|
|
// `apply_grip_menu_value`.
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn grip_menu_value_prompt(
|
|
|
|
|
&self,
|
|
|
|
|
_grip_id: usize,
|
2026-06-16 11:33:46 +03:00
|
|
|
action: crate::scene::model::object::GripMenuAction,
|
feat(grip): popup menus for polylines, spline, mline, hatch, leaders, text
Vocabulary added: AddFitPoint, RemoveFitPoint, Refit, RefineVertices,
TangentDirection, MoveWithText, StackText, UnstackText.
Polyline/Polyline2D/Polyline3D: vertex Add/Remove. MLine: same.
Spline: CV Add/Remove plus Refine Vertices (chord-midpoint insertion,
weights kept in sync, knots cleared so to_truck rebuilds uniform vec).
Hatch: centroid Origin/Angle/Scale (Angle and Scale prompt for value).
Leader: vertex Add/Remove (arrow + centroid stay Stretch-only).
MultiLeader: vertex Add/Remove Leader; MText location Move-with-Leader /
Move-Independent (menu live, structural edits stubbed). Text/MText:
Rotate prompts for degrees and sets rotation.
Spline, Leader, MultiLeader switched from impl_entity_basics! to manual
trait impls so grip_menu can be overridden.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-29 15:14:43 +03:00
|
|
|
) -> Option<&'static str> {
|
2026-06-16 11:33:46 +03:00
|
|
|
use crate::scene::model::object::GripMenuAction as A;
|
feat(grip): popup menus for polylines, spline, mline, hatch, leaders, text
Vocabulary added: AddFitPoint, RemoveFitPoint, Refit, RefineVertices,
TangentDirection, MoveWithText, StackText, UnstackText.
Polyline/Polyline2D/Polyline3D: vertex Add/Remove. MLine: same.
Spline: CV Add/Remove plus Refine Vertices (chord-midpoint insertion,
weights kept in sync, knots cleared so to_truck rebuilds uniform vec).
Hatch: centroid Origin/Angle/Scale (Angle and Scale prompt for value).
Leader: vertex Add/Remove (arrow + centroid stay Stretch-only).
MultiLeader: vertex Add/Remove Leader; MText location Move-with-Leader /
Move-Independent (menu live, structural edits stubbed). Text/MText:
Rotate prompts for degrees and sets rotation.
Spline, Leader, MultiLeader switched from impl_entity_basics! to manual
trait impls so grip_menu can be overridden.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-29 15:14:43 +03:00
|
|
|
match action {
|
|
|
|
|
A::HatchAngle => Some("Angle (deg)"),
|
|
|
|
|
A::HatchScale => Some("Scale"),
|
|
|
|
|
_ => None,
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn apply_grip_menu_value(
|
|
|
|
|
&mut self,
|
|
|
|
|
_grip_id: usize,
|
2026-06-16 11:33:46 +03:00
|
|
|
action: crate::scene::model::object::GripMenuAction,
|
feat(grip): popup menus for polylines, spline, mline, hatch, leaders, text
Vocabulary added: AddFitPoint, RemoveFitPoint, Refit, RefineVertices,
TangentDirection, MoveWithText, StackText, UnstackText.
Polyline/Polyline2D/Polyline3D: vertex Add/Remove. MLine: same.
Spline: CV Add/Remove plus Refine Vertices (chord-midpoint insertion,
weights kept in sync, knots cleared so to_truck rebuilds uniform vec).
Hatch: centroid Origin/Angle/Scale (Angle and Scale prompt for value).
Leader: vertex Add/Remove (arrow + centroid stay Stretch-only).
MultiLeader: vertex Add/Remove Leader; MText location Move-with-Leader /
Move-Independent (menu live, structural edits stubbed). Text/MText:
Rotate prompts for degrees and sets rotation.
Spline, Leader, MultiLeader switched from impl_entity_basics! to manual
trait impls so grip_menu can be overridden.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-29 15:14:43 +03:00
|
|
|
value: f64,
|
|
|
|
|
) {
|
2026-06-16 11:33:46 +03:00
|
|
|
use crate::scene::model::object::GripMenuAction as A;
|
feat(grip): popup menus for polylines, spline, mline, hatch, leaders, text
Vocabulary added: AddFitPoint, RemoveFitPoint, Refit, RefineVertices,
TangentDirection, MoveWithText, StackText, UnstackText.
Polyline/Polyline2D/Polyline3D: vertex Add/Remove. MLine: same.
Spline: CV Add/Remove plus Refine Vertices (chord-midpoint insertion,
weights kept in sync, knots cleared so to_truck rebuilds uniform vec).
Hatch: centroid Origin/Angle/Scale (Angle and Scale prompt for value).
Leader: vertex Add/Remove (arrow + centroid stay Stretch-only).
MultiLeader: vertex Add/Remove Leader; MText location Move-with-Leader /
Move-Independent (menu live, structural edits stubbed). Text/MText:
Rotate prompts for degrees and sets rotation.
Spline, Leader, MultiLeader switched from impl_entity_basics! to manual
trait impls so grip_menu can be overridden.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-29 15:14:43 +03:00
|
|
|
match action {
|
|
|
|
|
A::HatchAngle => {
|
|
|
|
|
self.pattern_angle = value.to_radians();
|
|
|
|
|
}
|
|
|
|
|
A::HatchScale => {
|
|
|
|
|
if value > 0.0 {
|
|
|
|
|
self.pattern_scale = value;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
_ => {}
|
|
|
|
|
}
|
|
|
|
|
}
|
2026-04-03 19:16:17 +03:00
|
|
|
}
|
refactor(tess): move per-entity tessellation into entities/
Each entity's tessellation now lives alongside its definition in
entities/*.rs, attached to the entity type via a local trait:
LegacyTess — Viewport / Insert / Hatch / Ole2Frame
(fallback path for entities not on the truck pipeline)
LeaderTess — Leader
MultiLeaderTess — MultiLeader
DimensionTess — Dimension (carries its dim-only helpers too:
~1700 lines of dim_geometry, dim_text_*, format_*,
tolerance, suppression, etc.)
scene/tessellate.rs keeps only the cross-entity dispatcher plus the
shared dim machinery reused by leader/multileader/dimension
(ArrowKind, DimGeom, append_arrow, arrow_from_block, add_segment,
add_polyline, normalized_or, push_tri, color_or_inherit, entity_z,
offset_snap_pts). Cross-entity arc helpers + aci_to_rgba moved to
scene/tess_util.rs.
scene/tessellate.rs shrinks from ~3300 to 809 lines. Compile clean,
all 9 tests pass.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:12:27 +03:00
|
|
|
|
2026-05-23 23:16:57 +03:00
|
|
|
impl FallbackTess for Hatch {
|
refactor: remove dead world_offset plumbing (RTE migration is complete)
Now that geometry reaches the GPU/CPU as absolute coordinates via the
double-single relative-to-eye path, world_offset is always [0,0,0]. Strip
the parameter that was threaded through the whole tessellation / block-
expansion / fallback / camera-decode chain and the ExpandCtx field that
carried it — ~340 references across 20 files, all subtracting zero.
- truck_tess: to_local / to_local_low / tessellate_* drop the offset arg;
to_local is now a pure double-single split.
- tessellate: offset_to_ds → points_to_ds (pure DS split); tessellate(),
tessellate_entity(), fallback_geometry(), solid_wire_fallback(),
entity_aabb(), expand_insert(), expand_block_meshes(), the dimension
helpers (vec3_local, dimension_snap_pts, …), text_support, leader,
multileader, image_model, xclip and camera_from_view all lose the param.
- block_cache: ExpandCtx loses its world_offset field.
- Remove the now-dead offset_snap_pts and the unused set_grid_snap.
Behaviour is unchanged (the offset was zero everywhere); the compiler
verifies every call site.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 18:35:02 +03:00
|
|
|
fn fallback_geometry(&self) -> FallbackGeometry {
|
refactor(tess): move per-entity tessellation into entities/
Each entity's tessellation now lives alongside its definition in
entities/*.rs, attached to the entity type via a local trait:
LegacyTess — Viewport / Insert / Hatch / Ole2Frame
(fallback path for entities not on the truck pipeline)
LeaderTess — Leader
MultiLeaderTess — MultiLeader
DimensionTess — Dimension (carries its dim-only helpers too:
~1700 lines of dim_geometry, dim_text_*, format_*,
tolerance, suppression, etc.)
scene/tessellate.rs keeps only the cross-entity dispatcher plus the
shared dim machinery reused by leader/multileader/dimension
(ArrowKind, DimGeom, append_arrow, arrow_from_block, add_segment,
add_polyline, normalized_or, push_tri, color_or_inherit, entity_z,
offset_snap_pts). Cross-entity arc helpers + aci_to_rgba moved to
scene/tess_util.rs.
scene/tessellate.rs shrinks from ~3300 to 809 lines. Compile clean,
all 9 tests pass.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:12:27 +03:00
|
|
|
let normal = (self.normal.x, self.normal.y, self.normal.z);
|
refactor: remove dead world_offset plumbing (RTE migration is complete)
Now that geometry reaches the GPU/CPU as absolute coordinates via the
double-single relative-to-eye path, world_offset is always [0,0,0]. Strip
the parameter that was threaded through the whole tessellation / block-
expansion / fallback / camera-decode chain and the ExpandCtx field that
carried it — ~340 references across 20 files, all subtracting zero.
- truck_tess: to_local / to_local_low / tessellate_* drop the offset arg;
to_local is now a pure double-single split.
- tessellate: offset_to_ds → points_to_ds (pure DS split); tessellate(),
tessellate_entity(), fallback_geometry(), solid_wire_fallback(),
entity_aabb(), expand_insert(), expand_block_meshes(), the dimension
helpers (vec3_local, dimension_snap_pts, …), text_support, leader,
multileader, image_model, xclip and camera_from_view all lose the param.
- block_cache: ExpandCtx loses its world_offset field.
- Remove the now-dead offset_snap_pts and the unused set_grid_snap.
Behaviour is unchanged (the offset was zero everywhere); the compiler
verifies every call site.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 18:35:02 +03:00
|
|
|
// Convert a 2D OCS hatch boundary point to absolute WCS.
|
2026-06-24 10:09:19 +03:00
|
|
|
let to_wcs = |x: f64, y: f64| -> [f64; 3] {
|
refactor(tess): move per-entity tessellation into entities/
Each entity's tessellation now lives alongside its definition in
entities/*.rs, attached to the entity type via a local trait:
LegacyTess — Viewport / Insert / Hatch / Ole2Frame
(fallback path for entities not on the truck pipeline)
LeaderTess — Leader
MultiLeaderTess — MultiLeader
DimensionTess — Dimension (carries its dim-only helpers too:
~1700 lines of dim_geometry, dim_text_*, format_*,
tolerance, suppression, etc.)
scene/tessellate.rs keeps only the cross-entity dispatcher plus the
shared dim machinery reused by leader/multileader/dimension
(ArrowKind, DimGeom, append_arrow, arrow_from_block, add_segment,
add_polyline, normalized_or, push_tri, color_or_inherit, entity_z,
offset_snap_pts). Cross-entity arc helpers + aci_to_rgba moved to
scene/tess_util.rs.
scene/tessellate.rs shrinks from ~3300 to 809 lines. Compile clean,
all 9 tests pass.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:12:27 +03:00
|
|
|
let (wx, wy, wz) =
|
2026-06-16 11:33:46 +03:00
|
|
|
crate::scene::view::transform::ocs_point_to_wcs((x, y, self.elevation), normal);
|
refactor: remove dead world_offset plumbing (RTE migration is complete)
Now that geometry reaches the GPU/CPU as absolute coordinates via the
double-single relative-to-eye path, world_offset is always [0,0,0]. Strip
the parameter that was threaded through the whole tessellation / block-
expansion / fallback / camera-decode chain and the ExpandCtx field that
carried it — ~340 references across 20 files, all subtracting zero.
- truck_tess: to_local / to_local_low / tessellate_* drop the offset arg;
to_local is now a pure double-single split.
- tessellate: offset_to_ds → points_to_ds (pure DS split); tessellate(),
tessellate_entity(), fallback_geometry(), solid_wire_fallback(),
entity_aabb(), expand_insert(), expand_block_meshes(), the dimension
helpers (vec3_local, dimension_snap_pts, …), text_support, leader,
multileader, image_model, xclip and camera_from_view all lose the param.
- block_cache: ExpandCtx loses its world_offset field.
- Remove the now-dead offset_snap_pts and the unused set_grid_snap.
Behaviour is unchanged (the offset was zero everywhere); the compiler
verifies every call site.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 18:35:02 +03:00
|
|
|
[wx, wy, wz]
|
refactor(tess): move per-entity tessellation into entities/
Each entity's tessellation now lives alongside its definition in
entities/*.rs, attached to the entity type via a local trait:
LegacyTess — Viewport / Insert / Hatch / Ole2Frame
(fallback path for entities not on the truck pipeline)
LeaderTess — Leader
MultiLeaderTess — MultiLeader
DimensionTess — Dimension (carries its dim-only helpers too:
~1700 lines of dim_geometry, dim_text_*, format_*,
tolerance, suppression, etc.)
scene/tessellate.rs keeps only the cross-entity dispatcher plus the
shared dim machinery reused by leader/multileader/dimension
(ArrowKind, DimGeom, append_arrow, arrow_from_block, add_segment,
add_polyline, normalized_or, push_tri, color_or_inherit, entity_z,
offset_snap_pts). Cross-entity arc helpers + aci_to_rgba moved to
scene/tess_util.rs.
scene/tessellate.rs shrinks from ~3300 to 809 lines. Compile clean,
all 9 tests pass.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:12:27 +03:00
|
|
|
};
|
2026-06-24 10:09:19 +03:00
|
|
|
// Snap point at a world (f64) location, cast to the f32 snap buffer.
|
|
|
|
|
let snap_at = |w: [f64; 3]| Vec3::new(w[0] as f32, w[1] as f32, w[2] as f32);
|
|
|
|
|
let mut pts: Vec<[f64; 3]> = Vec::new();
|
|
|
|
|
let mut key_verts: Vec<[f64; 3]> = Vec::new();
|
refactor(tess): move per-entity tessellation into entities/
Each entity's tessellation now lives alongside its definition in
entities/*.rs, attached to the entity type via a local trait:
LegacyTess — Viewport / Insert / Hatch / Ole2Frame
(fallback path for entities not on the truck pipeline)
LeaderTess — Leader
MultiLeaderTess — MultiLeader
DimensionTess — Dimension (carries its dim-only helpers too:
~1700 lines of dim_geometry, dim_text_*, format_*,
tolerance, suppression, etc.)
scene/tessellate.rs keeps only the cross-entity dispatcher plus the
shared dim machinery reused by leader/multileader/dimension
(ArrowKind, DimGeom, append_arrow, arrow_from_block, add_segment,
add_polyline, normalized_or, push_tri, color_or_inherit, entity_z,
offset_snap_pts). Cross-entity arc helpers + aci_to_rgba moved to
scene/tess_util.rs.
scene/tessellate.rs shrinks from ~3300 to 809 lines. Compile clean,
all 9 tests pass.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:12:27 +03:00
|
|
|
let mut snap_pts: Vec<(Vec3, SnapHint)> = Vec::new();
|
|
|
|
|
for path in &self.paths {
|
|
|
|
|
for edge in &path.edges {
|
|
|
|
|
match edge {
|
|
|
|
|
BoundaryEdge::Polyline(poly) => {
|
|
|
|
|
// Hatch-boundary polyline vertices encode bulge in
|
|
|
|
|
// `Vector3.z`; straight segments emit just the
|
|
|
|
|
// start vertex, bulged segments tessellate the arc
|
|
|
|
|
// between v0 → v1.
|
|
|
|
|
let verts = &poly.vertices;
|
|
|
|
|
let count = verts.len();
|
2026-05-26 18:16:40 +03:00
|
|
|
if count == 0 {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
// Break the wire between this polyline and whatever
|
|
|
|
|
// preceded it — without the separator the renderer
|
|
|
|
|
// draws a ghost segment from the previous edge / path
|
|
|
|
|
// straight to this polyline's first vertex, which
|
|
|
|
|
// shows up as a stray boundary line between hatch
|
|
|
|
|
// regions.
|
|
|
|
|
if !pts.is_empty() {
|
2026-06-24 10:09:19 +03:00
|
|
|
pts.push([f64::NAN; 3]);
|
2026-05-26 18:16:40 +03:00
|
|
|
}
|
|
|
|
|
let start_idx = pts.len();
|
refactor(tess): move per-entity tessellation into entities/
Each entity's tessellation now lives alongside its definition in
entities/*.rs, attached to the entity type via a local trait:
LegacyTess — Viewport / Insert / Hatch / Ole2Frame
(fallback path for entities not on the truck pipeline)
LeaderTess — Leader
MultiLeaderTess — MultiLeader
DimensionTess — Dimension (carries its dim-only helpers too:
~1700 lines of dim_geometry, dim_text_*, format_*,
tolerance, suppression, etc.)
scene/tessellate.rs keeps only the cross-entity dispatcher plus the
shared dim machinery reused by leader/multileader/dimension
(ArrowKind, DimGeom, append_arrow, arrow_from_block, add_segment,
add_polyline, normalized_or, push_tri, color_or_inherit, entity_z,
offset_snap_pts). Cross-entity arc helpers + aci_to_rgba moved to
scene/tess_util.rs.
scene/tessellate.rs shrinks from ~3300 to 809 lines. Compile clean,
all 9 tests pass.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:12:27 +03:00
|
|
|
let seg_count = if poly.is_closed {
|
|
|
|
|
count
|
|
|
|
|
} else {
|
|
|
|
|
count.saturating_sub(1)
|
|
|
|
|
};
|
|
|
|
|
for i in 0..seg_count {
|
|
|
|
|
let v0 = &verts[i];
|
|
|
|
|
let v1 = &verts[(i + 1) % count];
|
|
|
|
|
let bulge = v0.z;
|
refactor(common): unify bulge → arc math into BulgeArc
The same DXF/DWG bulge → (center, radius, sweep) formula was inlined
in six places (hatch outline, polyline tess + truck path, lwpolyline
×4, scene hatch fill, explode bulge_to_arc) — each with subtly
different sweep-direction handling for the bulge sign.
Add `entities::common::BulgeArc { center, radius, start_angle,
end_angle, sweep }` with one `from_bulge(p0, p1, bulge)` constructor
and a `sample(t)` helper. Callsites collapse to a few lines.
Net: -121 lines, one canonical sweep-direction convention shared by
all consumers.
array.rs (the path-along-curve f32 helper) keeps its inline math —
its sign convention is inverted relative to the others and changing
it without exercising the array-path command risks regressing the
output.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:42:26 +03:00
|
|
|
let arc = if bulge.abs() < 1e-9 {
|
|
|
|
|
None
|
|
|
|
|
} else {
|
|
|
|
|
crate::entities::common::BulgeArc::from_bulge(
|
|
|
|
|
[v0.x, v0.y],
|
|
|
|
|
[v1.x, v1.y],
|
|
|
|
|
bulge,
|
|
|
|
|
)
|
|
|
|
|
};
|
|
|
|
|
let Some(arc) = arc else {
|
refactor(tess): move per-entity tessellation into entities/
Each entity's tessellation now lives alongside its definition in
entities/*.rs, attached to the entity type via a local trait:
LegacyTess — Viewport / Insert / Hatch / Ole2Frame
(fallback path for entities not on the truck pipeline)
LeaderTess — Leader
MultiLeaderTess — MultiLeader
DimensionTess — Dimension (carries its dim-only helpers too:
~1700 lines of dim_geometry, dim_text_*, format_*,
tolerance, suppression, etc.)
scene/tessellate.rs keeps only the cross-entity dispatcher plus the
shared dim machinery reused by leader/multileader/dimension
(ArrowKind, DimGeom, append_arrow, arrow_from_block, add_segment,
add_polyline, normalized_or, push_tri, color_or_inherit, entity_z,
offset_snap_pts). Cross-entity arc helpers + aci_to_rgba moved to
scene/tess_util.rs.
scene/tessellate.rs shrinks from ~3300 to 809 lines. Compile clean,
all 9 tests pass.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:12:27 +03:00
|
|
|
let p = to_wcs(v0.x, v0.y);
|
|
|
|
|
pts.push(p);
|
|
|
|
|
key_verts.push(p);
|
|
|
|
|
continue;
|
refactor(common): unify bulge → arc math into BulgeArc
The same DXF/DWG bulge → (center, radius, sweep) formula was inlined
in six places (hatch outline, polyline tess + truck path, lwpolyline
×4, scene hatch fill, explode bulge_to_arc) — each with subtly
different sweep-direction handling for the bulge sign.
Add `entities::common::BulgeArc { center, radius, start_angle,
end_angle, sweep }` with one `from_bulge(p0, p1, bulge)` constructor
and a `sample(t)` helper. Callsites collapse to a few lines.
Net: -121 lines, one canonical sweep-direction convention shared by
all consumers.
array.rs (the path-along-curve f32 helper) keeps its inline math —
its sign convention is inverted relative to the others and changing
it without exercising the array-path command risks regressing the
output.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:42:26 +03:00
|
|
|
};
|
2026-06-11 00:04:37 +03:00
|
|
|
let segs = arc_segments(
|
|
|
|
|
arc.radius,
|
|
|
|
|
arc.sweep.abs(),
|
|
|
|
|
wire_chord_tol(arc.radius),
|
|
|
|
|
);
|
refactor(tess): move per-entity tessellation into entities/
Each entity's tessellation now lives alongside its definition in
entities/*.rs, attached to the entity type via a local trait:
LegacyTess — Viewport / Insert / Hatch / Ole2Frame
(fallback path for entities not on the truck pipeline)
LeaderTess — Leader
MultiLeaderTess — MultiLeader
DimensionTess — Dimension (carries its dim-only helpers too:
~1700 lines of dim_geometry, dim_text_*, format_*,
tolerance, suppression, etc.)
scene/tessellate.rs keeps only the cross-entity dispatcher plus the
shared dim machinery reused by leader/multileader/dimension
(ArrowKind, DimGeom, append_arrow, arrow_from_block, add_segment,
add_polyline, normalized_or, push_tri, color_or_inherit, entity_z,
offset_snap_pts). Cross-entity arc helpers + aci_to_rgba moved to
scene/tess_util.rs.
scene/tessellate.rs shrinks from ~3300 to 809 lines. Compile clean,
all 9 tests pass.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:12:27 +03:00
|
|
|
for j in 0..segs {
|
refactor(common): unify bulge → arc math into BulgeArc
The same DXF/DWG bulge → (center, radius, sweep) formula was inlined
in six places (hatch outline, polyline tess + truck path, lwpolyline
×4, scene hatch fill, explode bulge_to_arc) — each with subtly
different sweep-direction handling for the bulge sign.
Add `entities::common::BulgeArc { center, radius, start_angle,
end_angle, sweep }` with one `from_bulge(p0, p1, bulge)` constructor
and a `sample(t)` helper. Callsites collapse to a few lines.
Net: -121 lines, one canonical sweep-direction convention shared by
all consumers.
array.rs (the path-along-curve f32 helper) keeps its inline math —
its sign convention is inverted relative to the others and changing
it without exercising the array-path command risks regressing the
output.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:42:26 +03:00
|
|
|
let s = arc.sample(j as f64 / segs as f64);
|
|
|
|
|
let p = to_wcs(s[0], s[1]);
|
refactor(tess): move per-entity tessellation into entities/
Each entity's tessellation now lives alongside its definition in
entities/*.rs, attached to the entity type via a local trait:
LegacyTess — Viewport / Insert / Hatch / Ole2Frame
(fallback path for entities not on the truck pipeline)
LeaderTess — Leader
MultiLeaderTess — MultiLeader
DimensionTess — Dimension (carries its dim-only helpers too:
~1700 lines of dim_geometry, dim_text_*, format_*,
tolerance, suppression, etc.)
scene/tessellate.rs keeps only the cross-entity dispatcher plus the
shared dim machinery reused by leader/multileader/dimension
(ArrowKind, DimGeom, append_arrow, arrow_from_block, add_segment,
add_polyline, normalized_or, push_tri, color_or_inherit, entity_z,
offset_snap_pts). Cross-entity arc helpers + aci_to_rgba moved to
scene/tess_util.rs.
scene/tessellate.rs shrinks from ~3300 to 809 lines. Compile clean,
all 9 tests pass.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:12:27 +03:00
|
|
|
pts.push(p);
|
|
|
|
|
if j == 0 {
|
|
|
|
|
key_verts.push(p);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
// Close the loop visually for closed polylines by
|
|
|
|
|
// returning to the first emitted point.
|
|
|
|
|
if poly.is_closed {
|
|
|
|
|
if let Some(first) = pts.get(start_idx).cloned() {
|
|
|
|
|
if first[0].is_finite() {
|
|
|
|
|
pts.push(first);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
} else if let Some(last) = verts.last() {
|
|
|
|
|
let p = to_wcs(last.x, last.y);
|
|
|
|
|
pts.push(p);
|
|
|
|
|
key_verts.push(p);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
BoundaryEdge::Line(ln) => {
|
|
|
|
|
let p0 = to_wcs(ln.start.x, ln.start.y);
|
|
|
|
|
let p1 = to_wcs(ln.end.x, ln.end.y);
|
|
|
|
|
if !pts.is_empty() {
|
2026-06-24 10:09:19 +03:00
|
|
|
pts.push([f64::NAN; 3]);
|
refactor(tess): move per-entity tessellation into entities/
Each entity's tessellation now lives alongside its definition in
entities/*.rs, attached to the entity type via a local trait:
LegacyTess — Viewport / Insert / Hatch / Ole2Frame
(fallback path for entities not on the truck pipeline)
LeaderTess — Leader
MultiLeaderTess — MultiLeader
DimensionTess — Dimension (carries its dim-only helpers too:
~1700 lines of dim_geometry, dim_text_*, format_*,
tolerance, suppression, etc.)
scene/tessellate.rs keeps only the cross-entity dispatcher plus the
shared dim machinery reused by leader/multileader/dimension
(ArrowKind, DimGeom, append_arrow, arrow_from_block, add_segment,
add_polyline, normalized_or, push_tri, color_or_inherit, entity_z,
offset_snap_pts). Cross-entity arc helpers + aci_to_rgba moved to
scene/tess_util.rs.
scene/tessellate.rs shrinks from ~3300 to 809 lines. Compile clean,
all 9 tests pass.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:12:27 +03:00
|
|
|
}
|
|
|
|
|
pts.push(p0);
|
|
|
|
|
pts.push(p1);
|
|
|
|
|
key_verts.push(p0);
|
|
|
|
|
key_verts.push(p1);
|
|
|
|
|
}
|
|
|
|
|
BoundaryEdge::CircularArc(arc) => {
|
|
|
|
|
let (sa, span) =
|
|
|
|
|
arc_signed_span(arc.start_angle, arc.end_angle, arc.counter_clockwise);
|
|
|
|
|
let segs = arc_segments(arc.radius, span.abs(), wire_chord_tol(arc.radius));
|
|
|
|
|
if !pts.is_empty() {
|
2026-06-24 10:09:19 +03:00
|
|
|
pts.push([f64::NAN; 3]);
|
refactor(tess): move per-entity tessellation into entities/
Each entity's tessellation now lives alongside its definition in
entities/*.rs, attached to the entity type via a local trait:
LegacyTess — Viewport / Insert / Hatch / Ole2Frame
(fallback path for entities not on the truck pipeline)
LeaderTess — Leader
MultiLeaderTess — MultiLeader
DimensionTess — Dimension (carries its dim-only helpers too:
~1700 lines of dim_geometry, dim_text_*, format_*,
tolerance, suppression, etc.)
scene/tessellate.rs keeps only the cross-entity dispatcher plus the
shared dim machinery reused by leader/multileader/dimension
(ArrowKind, DimGeom, append_arrow, arrow_from_block, add_segment,
add_polyline, normalized_or, push_tri, color_or_inherit, entity_z,
offset_snap_pts). Cross-entity arc helpers + aci_to_rgba moved to
scene/tess_util.rs.
scene/tessellate.rs shrinks from ~3300 to 809 lines. Compile clean,
all 9 tests pass.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:12:27 +03:00
|
|
|
}
|
|
|
|
|
for i in 0..=segs {
|
|
|
|
|
let t = sa + span * (i as f64 / segs as f64);
|
|
|
|
|
let p = to_wcs(
|
|
|
|
|
arc.center.x + arc.radius * t.cos(),
|
|
|
|
|
arc.center.y + arc.radius * t.sin(),
|
|
|
|
|
);
|
|
|
|
|
pts.push(p);
|
|
|
|
|
if i == 0 || i == segs {
|
|
|
|
|
key_verts.push(p);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
snap_pts.push((
|
2026-06-24 10:09:19 +03:00
|
|
|
snap_at(to_wcs(arc.center.x, arc.center.y)),
|
refactor(tess): move per-entity tessellation into entities/
Each entity's tessellation now lives alongside its definition in
entities/*.rs, attached to the entity type via a local trait:
LegacyTess — Viewport / Insert / Hatch / Ole2Frame
(fallback path for entities not on the truck pipeline)
LeaderTess — Leader
MultiLeaderTess — MultiLeader
DimensionTess — Dimension (carries its dim-only helpers too:
~1700 lines of dim_geometry, dim_text_*, format_*,
tolerance, suppression, etc.)
scene/tessellate.rs keeps only the cross-entity dispatcher plus the
shared dim machinery reused by leader/multileader/dimension
(ArrowKind, DimGeom, append_arrow, arrow_from_block, add_segment,
add_polyline, normalized_or, push_tri, color_or_inherit, entity_z,
offset_snap_pts). Cross-entity arc helpers + aci_to_rgba moved to
scene/tess_util.rs.
scene/tessellate.rs shrinks from ~3300 to 809 lines. Compile clean,
all 9 tests pass.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:12:27 +03:00
|
|
|
SnapHint::Center,
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
BoundaryEdge::EllipticArc(ell) => {
|
|
|
|
|
let r_maj = (ell.major_axis_endpoint.x * ell.major_axis_endpoint.x
|
|
|
|
|
+ ell.major_axis_endpoint.y * ell.major_axis_endpoint.y)
|
|
|
|
|
.sqrt();
|
|
|
|
|
let r_min = r_maj * ell.minor_axis_ratio;
|
2026-06-11 00:04:37 +03:00
|
|
|
let rot = ell.major_axis_endpoint.y.atan2(ell.major_axis_endpoint.x);
|
refactor(tess): move per-entity tessellation into entities/
Each entity's tessellation now lives alongside its definition in
entities/*.rs, attached to the entity type via a local trait:
LegacyTess — Viewport / Insert / Hatch / Ole2Frame
(fallback path for entities not on the truck pipeline)
LeaderTess — Leader
MultiLeaderTess — MultiLeader
DimensionTess — Dimension (carries its dim-only helpers too:
~1700 lines of dim_geometry, dim_text_*, format_*,
tolerance, suppression, etc.)
scene/tessellate.rs keeps only the cross-entity dispatcher plus the
shared dim machinery reused by leader/multileader/dimension
(ArrowKind, DimGeom, append_arrow, arrow_from_block, add_segment,
add_polyline, normalized_or, push_tri, color_or_inherit, entity_z,
offset_snap_pts). Cross-entity arc helpers + aci_to_rgba moved to
scene/tess_util.rs.
scene/tessellate.rs shrinks from ~3300 to 809 lines. Compile clean,
all 9 tests pass.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:12:27 +03:00
|
|
|
let (sa, span) =
|
|
|
|
|
arc_signed_span(ell.start_angle, ell.end_angle, ell.counter_clockwise);
|
|
|
|
|
let segs = arc_segments(r_maj, span.abs(), wire_chord_tol(r_maj));
|
|
|
|
|
if !pts.is_empty() {
|
2026-06-24 10:09:19 +03:00
|
|
|
pts.push([f64::NAN; 3]);
|
refactor(tess): move per-entity tessellation into entities/
Each entity's tessellation now lives alongside its definition in
entities/*.rs, attached to the entity type via a local trait:
LegacyTess — Viewport / Insert / Hatch / Ole2Frame
(fallback path for entities not on the truck pipeline)
LeaderTess — Leader
MultiLeaderTess — MultiLeader
DimensionTess — Dimension (carries its dim-only helpers too:
~1700 lines of dim_geometry, dim_text_*, format_*,
tolerance, suppression, etc.)
scene/tessellate.rs keeps only the cross-entity dispatcher plus the
shared dim machinery reused by leader/multileader/dimension
(ArrowKind, DimGeom, append_arrow, arrow_from_block, add_segment,
add_polyline, normalized_or, push_tri, color_or_inherit, entity_z,
offset_snap_pts). Cross-entity arc helpers + aci_to_rgba moved to
scene/tess_util.rs.
scene/tessellate.rs shrinks from ~3300 to 809 lines. Compile clean,
all 9 tests pass.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:12:27 +03:00
|
|
|
}
|
|
|
|
|
let (cr, sr) = (rot.cos(), rot.sin());
|
|
|
|
|
for i in 0..=segs {
|
|
|
|
|
let t = sa + span * (i as f64 / segs as f64);
|
|
|
|
|
let lx = r_maj * t.cos();
|
|
|
|
|
let ly = r_min * t.sin();
|
|
|
|
|
let p = to_wcs(
|
|
|
|
|
ell.center.x + lx * cr - ly * sr,
|
|
|
|
|
ell.center.y + lx * sr + ly * cr,
|
|
|
|
|
);
|
|
|
|
|
pts.push(p);
|
|
|
|
|
if i == 0 || i == segs {
|
|
|
|
|
key_verts.push(p);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
snap_pts.push((
|
2026-06-24 10:09:19 +03:00
|
|
|
snap_at(to_wcs(ell.center.x, ell.center.y)),
|
refactor(tess): move per-entity tessellation into entities/
Each entity's tessellation now lives alongside its definition in
entities/*.rs, attached to the entity type via a local trait:
LegacyTess — Viewport / Insert / Hatch / Ole2Frame
(fallback path for entities not on the truck pipeline)
LeaderTess — Leader
MultiLeaderTess — MultiLeader
DimensionTess — Dimension (carries its dim-only helpers too:
~1700 lines of dim_geometry, dim_text_*, format_*,
tolerance, suppression, etc.)
scene/tessellate.rs keeps only the cross-entity dispatcher plus the
shared dim machinery reused by leader/multileader/dimension
(ArrowKind, DimGeom, append_arrow, arrow_from_block, add_segment,
add_polyline, normalized_or, push_tri, color_or_inherit, entity_z,
offset_snap_pts). Cross-entity arc helpers + aci_to_rgba moved to
scene/tess_util.rs.
scene/tessellate.rs shrinks from ~3300 to 809 lines. Compile clean,
all 9 tests pass.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 23:12:27 +03:00
|
|
|
SnapHint::Center,
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
_ => {}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if pts.is_empty() {
|
|
|
|
|
pts = vec![[0.0, 0.0, 0.0], [0.0, 0.0, 0.0]];
|
|
|
|
|
}
|
|
|
|
|
(pts, snap_pts, vec![], key_verts)
|
|
|
|
|
}
|
|
|
|
|
}
|